adding testing workflow for libabigail #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this workflow uses the fedora base, and adds the new code (from the PR) to then run make check. I am also updating the current fedora container to also use the base Signed-off-by: vsoch <vsoch@users.noreply.github.com>
|
Here is the local failure (which I suspect we will reproduce with the container): #9 3.128 libtoolize: putting auxiliary files in AC_CONFIG_AUX_DIR, 'build-aux'.
#9 3.128 libtoolize: copying file 'build-aux/ltmain.sh'
#9 3.150 libtoolize: putting macros in AC_CONFIG_MACRO_DIRS, 'm4'.
#9 3.150 libtoolize: copying file 'm4/libtool.m4'
#9 3.169 libtoolize: copying file 'm4/ltoptions.m4'
#9 3.187 libtoolize: copying file 'm4/ltsugar.m4'
#9 3.203 libtoolize: copying file 'm4/ltversion.m4'
#9 3.222 libtoolize: copying file 'm4/lt~obsolete.m4'
#9 5.457 configure.ac:171: installing 'build-aux/compile'
#9 5.459 configure.ac:170: installing 'build-aux/config.guess'
#9 5.460 configure.ac:170: installing 'build-aux/config.sub'
#9 5.463 configure.ac:33: installing 'build-aux/install-sh'
#9 5.465 configure.ac:33: installing 'build-aux/missing'
#9 5.642 src/Makefile.am: installing 'build-aux/depcomp'
#9 5.744 parallel-tests: installing 'build-aux/test-driver'
#9 5.967 checking for a BSD-compatible install... /usr/bin/install -c
#9 5.974 checking whether build environment is sane... yes
#9 5.982 checking for a thread-safe mkdir -p... /usr/bin/mkdir -p
#9 5.984 checking for gawk... gawk
#9 5.984 checking whether make sets $(MAKE)... yes
#9 5.996 checking whether make supports nested variables... yes
#9 6.005 checking whether UID '0' is supported by ustar format... yes
#9 6.005 checking whether GID '0' is supported by ustar format... yes
#9 6.005 checking how to create a ustar tar archive... gnutar
#9 6.019 checking whether to enable maintainer-specific portions of Makefiles... yes
#9 6.019 checking whether make supports nested variables... (cached) yes
#9 6.020 checking for g++... g++
#9 6.038 checking whether the C++ compiler works... yes
#9 6.172 checking for C++ compiler default output file name... a.out
#9 6.173 checking for suffix of executables...
#9 6.266 checking whether we are cross compiling... no
#9 6.380 checking for suffix of object files... o
#9 6.402 checking whether we are using the GNU C++ compiler... yes
#9 6.422 checking whether g++ accepts -g... yes
#9 6.439 checking whether make supports the include directive... yes (GNU style)
#9 6.446 checking dependency style of g++... gcc3
#9 6.478 checking build system type... x86_64-pc-linux-gnu
#9 6.523 checking host system type... x86_64-pc-linux-gnu
#9 6.523 checking for gcc... gcc
#9 6.538 checking whether we are using the GNU C compiler... yes
#9 6.568 checking whether gcc accepts -g... yes
#9 6.584 checking for gcc option to accept ISO C89... none needed
#9 6.624 checking whether gcc understands -c and -o together... yes
#9 6.661 checking dependency style of gcc... gcc3
#9 6.692 checking how to run the C preprocessor... gcc -E
#9 6.735 checking for grep that handles long lines and -e... /usr/bin/grep
#9 6.737 checking for egrep... /usr/bin/grep -E
#9 6.739 checking for ANSI C header files... yes
#9 6.848 checking for sys/types.h... yes
#9 6.879 checking for sys/stat.h... yes
#9 6.908 checking for stdlib.h... yes
#9 6.940 checking for string.h... yes
#9 6.972 checking for memory.h... yes
#9 7.006 checking for strings.h... yes
#9 7.038 checking for inttypes.h... yes
#9 7.074 checking for stdint.h... yes
#9 7.107 checking for unistd.h... yes
#9 7.147 checking minix/config.h usability... no
#9 7.181 checking minix/config.h presence... no
#9 7.192 checking for minix/config.h... no
#9 7.192 checking whether it is safe to define __EXTENSIONS__... yes
#9 7.237 checking how to print strings... printf
#9 7.238 checking for a sed that does not truncate output... /usr/bin/sed
#9 7.241 checking for fgrep... /usr/bin/grep -F
#9 7.242 checking for ld used by gcc... /usr/bin/ld
#9 7.245 checking if the linker (/usr/bin/ld) is GNU ld... yes
#9 7.247 checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
#9 7.249 checking the name lister (/usr/bin/nm -B) interface... BSD nm
#9 7.265 checking whether ln -s works... yes
#9 7.265 checking the maximum length of command line arguments... 1572864
#9 7.271 checking how to convert x86_64-pc-linux-gnu file names to x86_64-pc-linux-gnu format... func_convert_file_noop
#9 7.271 checking how to convert x86_64-pc-linux-gnu file names to toolchain format... func_convert_file_noop
#9 7.271 checking for /usr/bin/ld option to reload object files... -r
#9 7.272 checking for objdump... objdump
#9 7.272 checking how to recognize dependent libraries... pass_all
#9 7.272 checking for dlltool... no
#9 7.273 checking how to associate runtime and link libraries... printf %s\n
#9 7.273 checking for ar... ar
#9 7.273 checking for archiver @FILE support... @
#9 7.299 checking for strip... strip
#9 7.300 checking for ranlib... ranlib
#9 7.300 checking command to parse /usr/bin/nm -B output from gcc object... ok
#9 7.360 checking for sysroot... no
#9 7.360 checking for a working dd... ../configure: line 8069: cmp: command not found
#9 7.363 ../configure: line 8069: cmp: command not found
#9 7.364
#9 7.364 checking how to truncate binary pipes... /usr/bin/sed -e 4q
#9 7.376 ../configure: line 8246: /usr/bin/file: No such file or directory
#9 7.377 checking for mt... no
#9 7.377 checking if : is a manifest tool... no
#9 7.380 checking for dlfcn.h... yes
#9 7.420 checking for objdir... .libs
#9 7.473 checking if gcc supports -fno-rtti -fno-exceptions... ../configure: line 9746: diff: command not found
#9 7.491 no
#9 7.491 checking for gcc option to produce PIC... -fPIC -DPIC
#9 7.491 checking if gcc PIC flag -fPIC -DPIC works... yes
#9 7.507 checking if gcc static flag -static works... no
#9 7.527 checking if gcc supports -c -o file.o... yes
#9 7.549 checking if gcc supports -c -o file.o... (cached) yes
#9 7.549 checking whether the gcc linker (/usr/bin/ld) supports shared libraries... yes
#9 7.558 checking whether -lc should be explicitly linked in... no
#9 7.590 checking dynamic linker characteristics... GNU/Linux ld.so
#9 7.660 checking how to hardcode library paths into programs... immediate
#9 7.660 checking whether stripping libraries is possible... yes
#9 7.662 checking if libtool supports shared libraries... yes
#9 7.662 checking whether to build shared libraries... yes
#9 7.662 checking whether to build static libraries... yes
#9 7.665 checking how to run the C++ preprocessor... g++ -E
#9 7.819 checking for ld used by g++... /usr/bin/ld
#9 7.821 checking if the linker (/usr/bin/ld) is GNU ld... yes
#9 7.827 checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes
#9 7.948 checking for g++ option to produce PIC... -fPIC -DPIC
#9 7.948 checking if g++ PIC flag -fPIC -DPIC works... yes
#9 7.973 checking if g++ static flag -static works... no
#9 7.998 checking if g++ supports -c -o file.o... yes
#9 8.027 checking if g++ supports -c -o file.o... (cached) yes
#9 8.027 checking whether the g++ linker (/usr/bin/ld) supports shared libraries... yes
#9 8.027 checking dynamic linker characteristics... (cached) GNU/Linux ld.so
#9 8.032 checking how to hardcode library paths into programs... immediate
#9 8.032 configure: checking for GCC visibility attribute support ...
#9 8.056 configure: GCC visibility attribute is supported
#9 8.056 checking whether including fts.h with _FILE_OFFSET_BITS set breaks... no
#9 8.077 checking for pkg-config... /usr/bin/pkg-config
#9 8.078 checking pkg-config is at least version 0.9.0... yes
#9 8.091 checking for elf_end in -lelf... yes
#9 8.192 checking libelf.h usability... yes
#9 8.270 checking libelf.h presence... yes
#9 8.283 checking for libelf.h... yes
#9 8.283 checking for dwfl_begin in -ldw... yes
#9 8.368 checking for dwarf_getalt in -ldw... yes
#9 8.471 checking elfutils/libdwfl.h usability... yes
#9 8.548 checking elfutils/libdwfl.h presence... yes
#9 8.566 checking for elfutils/libdwfl.h... yes
#9 8.566 checking whether to enable assertions... yes
#9 8.566 checking for XML... yes
#9 8.591 checking for rm... yes
#9 8.592 checking for mkdir... yes
#9 8.592 checking for rpm2cpio... yes
#9 8.592 checking for cpio... yes
#9 8.593 checking for rpm... yes
#9 8.593 checking for rpm/zstd support... yes
#9 8.599 configure: rpm support in abipkgdiff is enabled
#9 8.599 configure: rpm/zstd in abipkgdiff testing is enabled
#9 8.599 configure: support of debugging self comparison is disabled
#9 8.599 configure: support of abilint --show-type-use <type-id> is disabled
#9 8.599 configure: support of debugging type canonicalization is disabled
#9 8.599 checking for dpkg... no
#9 8.600 configure: deb support in abipkgdiff is disabled
#9 8.600 checking for tar... yes
#9 8.600 configure: GNU tar support in abipkgdiff is enabled
#9 8.600 checking for bash-completion... no
#9 8.601 configure: bash-completion support in libabigail is disabled
#9 8.601 checking for python... no
#9 8.601 checking for python version...
#9 8.609 checking for python3... python3
#9 8.609 configure: no minimal version of python found
#9 8.609 configure: python binary wasn't found
#9 8.609 configure: using python3 instead
#9 8.610 checking for wget... /usr/bin/wget
#9 8.611 checking python3 module: argparse... yes
#9 8.644 checking python3 module: logging... yes
#9 8.675 checking python3 module: os... yes
#9 8.690 checking python3 module: re... yes
#9 8.713 checking python3 module: subprocess... yes
#9 8.741 checking python3 module: sys... yes
#9 8.756 checking python3 module: urllib.parse... yes
#9 8.780 checking python3 module: xdg... yes
#9 8.795 checking python3 module: koji... yes
#9 9.045 checking python3 module: mock... yes
#9 9.117 checking python3 module: rpm... yes
#9 9.151 checking python3 module: imp... yes
#9 9.183 checking python3 module: tempfile... yes
#9 9.217 checking python3 module: mimetypes... yes
#9 9.242 checking python3 module: shutil... yes
#9 9.272 checking python3 module: six... yes
#9 9.297 checking if koji client is recent enough... yes
#9 9.498 checking for doxygen... no
#9 9.499 checking for sphinx-build... no
#9 9.500 checking for valgrind... no
#9 9.508 checking whether EM_AARCH64 is declared... yes
#9 9.551 checking whether EM_TILEPRO is declared... yes
#9 9.593 checking whether EM_TILEGX is declared... yes
#9 9.629 checking whether R_AARCH64_ABS64 is declared... yes
#9 9.663 checking whether R_AARCH64_PREL32 is declared... yes
#9 9.699 checking whether DW_LANG_UPC is declared... yes
#9 9.724 checking whether DW_LANG_D is declared... yes
#9 9.751 checking whether DW_LANG_Python is declared... yes
#9 9.779 checking whether DW_LANG_Go is declared... yes
#9 9.803 checking whether DW_LANG_C11 is declared... yes
#9 9.828 checking whether DW_LANG_C_plus_plus_03 is declared... yes
#9 9.852 checking whether DW_LANG_C_plus_plus_11 is declared... yes
#9 9.879 checking whether DW_LANG_C_plus_plus_14 is declared... yes
#9 9.906 checking whether DW_LANG_Mips_Assembler is declared... yes
#9 9.936 checking whether DW_LANG_Rust is declared... yes
#9 9.962 checking whether DW_FORM_strx1 is declared... yes
#9 9.989 checking whether DW_FORM_strx2 is declared... yes
#9 10.01 checking whether DW_FORM_strx3 is declared... yes
#9 10.04 checking whether DW_FORM_strx4 is declared... yes
#9 10.07 checking whether DW_FORM_line_strp is declared... yes
#9 10.09 checking for special C compiler options needed for large files... no
#9 10.09 checking for _FILE_OFFSET_BITS value needed for large files... no
#9 10.14 checking that generated files are newer than configure... done
#9 10.14 configure: creating ./config.status
#9 10.72 config.status: creating Makefile
#9 10.73 config.status: creating libabigail.pc
#9 10.74 config.status: creating include/Makefile
#9 10.76 config.status: creating include/abg-version.h
#9 10.77 config.status: creating doc/Makefile
#9 10.79 config.status: creating doc/manuals/Makefile
#9 10.81 config.status: creating src/Makefile
#9 10.82 config.status: creating tools/Makefile
#9 10.84 config.status: creating tests/Makefile
#9 10.86 config.status: creating tests/data/Makefile
#9 10.88 config.status: creating bash-completion/Makefile
#9 10.90 config.status: creating tests/runtestcanonicalizetypes.sh
#9 10.91 config.status: creating tests/runtestslowselfcompare.sh
#9 10.93 config.status: creating tests/mockfedabipkgdiff
#9 10.95 config.status: creating tests/runtestfedabipkgdiff.py
#9 10.96 config.status: creating tests/runtestfedabipkgdiffpy3.sh
#9 10.97 config.status: creating tests/runtestdefaultsupprs.py
#9 10.99 config.status: creating tests/runtestdefaultsupprspy3.sh
#9 11.01 config.status: creating config.h
#9 11.02 config.status: executing depfiles commands
#9 11.25 config.status: executing libtool commands
#9 11.26 configure:
#9 11.26 =====================================================================
#9 11.26 Libabigail: 2.1.0
#9 11.26 =====================================================================
#9 11.26
#9 11.26 Here is the configuration of the package:
#9 11.26
#9 11.26 Prefix : /opt/libabigail
#9 11.26 Source code location : ..
#9 11.26 C Compiler : gcc
#9 11.26 C++ Compiler : g++
#9 11.26 GCC visibility attribute supported : yes
#9 11.26 CXXFLAGS : -g3 -fvar-tracking-assignments -gstatement-frontiers -gvariable-location-views -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fstack-clash-protection -fcf-protection -fasynchronous-unwind-tables -O2 -std=c++11
#9 11.26 Python : python3
#9 11.26
#9 11.26 OPTIONAL FEATURES:
#9 11.26 C++ standard level : c++11
#9 11.26 libdw has the dwarf_getalt function : yes
#9 11.26 Enable rpm support in abipkgdiff : yes
#9 11.26 Enable rpm/zstd in abipkgdiff testing : yes
#9 11.26 Enable abilint --show-type-use <type-id> : no
#9 11.26 Enable self comparison debugging : no
#9 11.26 Enable type canonicalization debugging : no
#9 11.26 Enable deb support in abipkgdiff : no
#9 11.26 Enable GNU tar archive support in abipkgdiff : yes
#9 11.26 Enable bash completion : no
#9 11.26 Enable fedabipkgdiff : yes
#9 11.26 Enable python 3 : yes
#9 11.26 Enable CTF front-end : no
#9 11.26 Enable running tests under Valgrind : no
#9 11.26 Enable build with -fsanitize=address : no
#9 11.26 Enable build with -fsanitize=memory : no
#9 11.26 Enable build with -fsanitize=thread : no
#9 11.26 Enable build with -fsanitize=undefined : no
#9 11.26 Generate html apidoc : no
#9 11.26 Generate html manual : no
#9 11.26
#9 11.29 make --no-print-directory all-recursive
#9 11.30 Making all in include
#9 11.30 make[2]: Nothing to be done for 'all'.
#9 11.30 Making all in src
#9 11.30 CXX abg-traverse.lo
#9 11.30 CXX abg-ir.lo
#9 11.30 CXX abg-corpus.lo
#9 11.31 CXX abg-diff-utils.lo
#9 12.64 CXX abg-comparison.lo
#9 16.59 CXX abg-reporter-priv.lo
#9 30.26 CXX abg-default-reporter.lo
#9 30.82 CXX abg-leaf-reporter.lo
#9 44.16 CXX abg-suppression.lo
#9 48.03 CXX abg-comp-filter.lo
#9 60.12 CXX abg-reader.lo
#9 67.43 CXX abg-elf-reader-common.lo
#9 68.70 CXX abg-dwarf-reader.lo
#9 93.83 CXX abg-libxml-utils.lo
#9 95.96 CXX abg-hash.lo
#9 99.00 CXX abg-writer.lo
#9 99.06 CXX abg-config.lo
#9 100.00 CXX abg-ini.lo
#9 102.2 CXX abg-workers.lo
#9 105.2 CXX abg-tools-utils.lo
#9 112.2 CXX abg-elf-helpers.lo
#9 118.5 CXX abg-regex.lo
#9 120.5 CXX abg-symtab-reader.lo
#9 121.5 CXX abg-viz-common.lo
#9 123.2 CXX abg-viz-dot.lo
#9 123.8 CXX abg-viz-svg.lo
#9 129.4 CXXLD libabigail.la
#9 131.3 Making all in tools
#9 131.3 CXX abidiff.o
#9 131.3 CXX abidw.o
#9 131.3 CXX abilint.o
#9 131.3 CXX abicompat.o
#9 134.4 CXX abipkgdiff-abipkgdiff.o
#9 134.9 CXX kmidiff.o
#9 135.4 CXX abisym.o
#9 135.8 CXX binilint.o
#9 136.6 CXXLD abidiff
#9 137.0 CXXLD abilint
#9 137.3 CXXLD abidw
#9 137.5 CXXLD abicompat
#9 137.6 CXXLD abisym
#9 137.8 CXXLD abinilint
#9 137.8 CXXLD kmidiff
#9 142.6 CXXLD abipkgdiff
#9 142.8 Making all in tests
#9 142.8 Making all in data
#9 142.8 make[3]: Nothing to be done for 'all'.
#9 142.8 CXX test-diff-suppr.o
#9 142.8 CXX libtestutils_la-test-utils.lo
#9 142.8 CXX test-types-stability.o
#9 142.8 CXX test-diff-pkg.o
#9 143.8 CXX test-annotate.o
#9 145.2 CXX test-diff-filter.o
#9 145.5 CXX test-read-dwarf.o
#9 146.0 CXX libtestreadcommon_la-test-read-common.lo
#9 146.1 CXX test-abicompat.o
#9 148.0 CXX test-abidiff.o
#9 148.5 CXX test-abidiff-exit.o
#9 149.0 CXX test-alt-dwarf-file.o
#9 151.1 CXX test-core-diff.o
#9 151.3 CXX test-cxx-compat.o
#9 151.6 CXX test-diff-dwarf.o
#9 151.8 CXX test-diff-dwarf-abixml.o
#9 152.6 CXX test-elf-helpers.o
#9 153.3 CXX test-ini.o
#9 154.0 CXX test-kmi-whitelist.o
#9 154.4 CXX test-lookup-syms.o
#9 154.5 CXX test-read-write.o
#9 155.9 CXX test-symtab.o
#9 156.8 CXX test-symtab-reader.o
#9 157.3 CXX test-tools-utils.o
#9 157.4 CXX test-svg.o
#9 158.2 CXX test-ir-walker.o
#9 158.7 CXX test-diff2.o
#9 159.5 CXX print-diff-tree.o
#9 159.9 CXXLD libtestutils.la
#9 160.1 CXXLD libtestreadcommon.la
#9 160.4 CXXLD runtestabicompat
#9 160.5 CXXLD runtestabidiff
#9 160.7 CXXLD runtestabidiffexit
#9 160.8 CXXLD runtestaltdwarf
#9 161.1 CXXLD runtestcorediff
#9 161.1 CXX lib/catch.lo
#9 161.4 CXXLD runtestdiffdwarf
#9 161.7 CXXLD runtestdiffdwarfabixml
#9 161.8 CXXLD runtestini
#9 162.0 CXXLD runtestlookupsyms
#9 162.2 CXXLD runtestreadwrite
#9 162.3 CXXLD runtesttoolsutils
#9 162.5 CXXLD runtestsvg
#9 162.6 CXXLD testirwalker
#9 162.8 CXXLD testdiff2
#9 162.9 CXXLD printdifftree
#9 163.2 CXXLD runtestdiffsuppr
#9 163.2 CXXLD runtesttypesstability
#9 163.4 CXXLD runtestdiffpkg
#9 163.5 CXXLD runtestannotate
#9 163.5 CXXLD runtestdifffilter
#9 163.7 CXXLD runtestreaddwarf
#9 218.4 CXXLD libcatch.la
#9 218.6 CXXLD runtestcxxcompat
#9 218.6 CXXLD runtestelfhelpers
#9 218.6 CXXLD runtestkmiwhitelist
#9 218.6 CXXLD runtestsymtab
#9 219.1 CXXLD runtestsymtabreader
#9 219.5 Making all in doc
#9 219.5 Making all in manuals
#9 219.5 make[3]: Nothing to be done for 'all'.
#9 219.6 make[3]: Nothing to be done for 'all-am'.
#9 219.6 Making all in bash-completion
#9 219.6 make[2]: Nothing to be done for 'all'.
#9 219.6 Making check in include
#9 219.6 make[1]: Nothing to be done for 'check'.
#9 219.6 Making check in src
#9 219.6 make[1]: Nothing to be done for 'check'.
#9 219.6 Making check in tools
#9 219.6 make[1]: Nothing to be done for 'check'.
#9 219.6 Making check in tests
#9 219.6 Making check in data
#9 219.6 make[2]: Nothing to be done for 'check'.
#9 219.7 make check-TESTS
#9 219.7 PASS: runtestslowselfcompare.sh
#9 225.5 FAIL: runtestdiffsuppr
#9 259.9 PASS: runtesttypesstability
#9 286.9 FAIL: runtestdiffpkg
#9 290.7 FAIL: runtestannotate
#9 301.3 FAIL: runtestdifffilter
#9 311.0 FAIL: runtestreaddwarf
#9 315.1 PASS: runtestcanonicalizetypes.sh
#9 315.5 FAIL: runtestabicompat
#9 315.8 FAIL: runtestabidiff
#9 316.6 FAIL: runtestabidiffexit
#9 340.6 FAIL: runtestaltdwarf
#9 340.6 FAIL: runtestcorediff
#9 340.6 PASS: runtestcxxcompat
#9 341.2 FAIL: runtestdiffdwarf
#9 341.7 FAIL: runtestdiffdwarfabixml
#9 341.7 PASS: runtestelfhelpers
#9 341.8 FAIL: runtestini
#9 341.8 PASS: runtestkmiwhitelist
#9 341.9 FAIL: runtestlookupsyms
#9 342.1 FAIL: runtestreadwrite
#9 342.2 PASS: runtestsymtab
#9 342.2 PASS: runtestsymtabreader
#9 342.2 PASS: runtesttoolsutils
#9 342.2 PASS: runtestsvg
#9 343.1 FAIL: runtestfedabipkgdiffpy3.sh
#9 343.2 FAIL: runtestdefaultsupprspy3.sh
#9 343.2 ============================================================================
#9 343.2 Testsuite summary for libabigail 2.1
#9 343.2 ============================================================================
#9 343.2 # TOTAL: 27
#9 343.2 # PASS: 10
#9 343.2 # SKIP: 0
#9 343.2 # XFAIL: 0
#9 343.2 # FAIL: 17
#9 343.2 # XPASS: 0
#9 343.2 # ERROR: 0
#9 343.2 ============================================================================
#9 343.2 See tests/test-suite.log
#9 343.2 Please report to http://sourceware.org/bugzilla
#9 343.2 ============================================================================
#9 343.2 make[4]: *** [Makefile:1392: test-suite.log] Error 1
#9 343.2 make[3]: *** [Makefile:1500: check-TESTS] Error 2
#9 343.2 make[2]: *** [Makefile:1801: check-am] Error 2
#9 343.2 make[1]: *** [Makefile:1284: check-recursive] Error 1
#9 343.2 make: *** [Makefile:577: check-recursive] Error 1
------ |
|
In the deps add: It looks like that contains the missing file. |
|
also add "file", I missed that one the first time I read through it. |
we want to do this for the fedora and testing container (coming in subsequent PR) to use. Right now, we will need to reinstall the same deps because the fedora libabigail image is a multistage build and does not provide them. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
woodard
requested changes
Apr 21, 2022
docker/Dockerfile.test
Outdated
| RUN dnf install -y \ | ||
| file \ | ||
| diffutils \ | ||
| elfutils-libs \ |
There was a problem hiding this comment.
I think that these shouldn't be necessary here because we have the devel packages in the build environment. I may have lost the control logic though. If they are needed here then there are a few more runtime libs needed.
There was a problem hiding this comment.
We would have only elfutils-libs in the fedora base container, but not the other two (since we are removing them). I'm adding them all here because we haven't built -> deployed the base container with these changes yet.
|
So apparently we have 2 tests that are failing. Is there a way that I can see the "tests/test-suite.log" so that I can see what failed? |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
woodard
requested changes
Apr 21, 2022
| @@ -33,4 +33,5 @@ RUN dnf install -y \ | |||
| elfutils-libelf \ | |||
| elfutils-libs \ | |||
| libstdc++ \ | |||
| lbzip2 \ | |||
There was a problem hiding this comment.
I think this is only needed in the test container.
docker/Dockerfile.fedora-base
Outdated
| @@ -16,4 +16,5 @@ RUN dnf install -y \ | |||
| python3-mock \ | |||
| python3-pyxdg \ | |||
| six \ | |||
| lbzip2 \ | |||
|
hmm let me figure out why fedabipkgdiff failed. Initial hypothesis is that it has something to do with python dependencies. |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
woodard
reviewed
Apr 22, 2022
| @@ -10,11 +10,12 @@ RUN dnf install -y \ | |||
| cpio \ | |||
| elfutils-devel \ | |||
| gcc-c++ \ | |||
| lbzip2 \ | |||
There was a problem hiding this comment.
nit shouldn't this be below the other libs
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this workflow uses the fedora base, and adds the new code (from the PR) to then
run make check. I am also updating the current fedora container to also use the base.
Note that the tests for me failed locally with this build - we'll need to inspect that if it should not happen!
Signed-off-by: vsoch vsoch@users.noreply.github.com