Make startScan() async and check BLE availability #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is |
|
Because if there isn't an available BLE adapter or its turned off on the system, it causes a native crash, which makes the entire app crash. I'm trying to prevent against native crashes for any reason. |
Signed-off-by: wangkun <wangkun@woodemi.com>
|
Fix async & format |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, if
startScan()is called while the Bluetooth switch is in the "off" state, quick_blue causes a native crash.This PR first checks that Bluetooth is enabled, and if it is not, returns an error back up to the Flutter system to deal with.
It also changes the implementation of
startScantoasync. That's because, in my tests, it seems like the error was only caught properly ifstartScanwas made async.EDIT: Also check if the bluetooth adapter is available before trying to use it. It's possible that the bluetooth object could be null if there was no eligible hardware to be used on the computer.