Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore agents that are not sufficient for pending workload #133

Open
xoxys opened this issue Apr 21, 2024 · 3 comments
Open

Ignore agents that are not sufficient for pending workload #133

xoxys opened this issue Apr 21, 2024 · 3 comments
Labels
enhancement Enhance existing feature

Comments

@xoxys
Copy link
Member

xoxys commented Apr 21, 2024

If static agents with free capacities exist, but the agents cannot process pending workload due to their configuration, e.g. due to labels, the autoscaler still does not create any agents.

@xoxys xoxys closed this as completed Apr 21, 2024
@xoxys xoxys reopened this Apr 22, 2024
@xoxys
Copy link
Member Author

xoxys commented Apr 22, 2024

Checked again, this setup definitely causes problems.

@xoxys xoxys added the enhancement Enhance existing feature label Apr 22, 2024
@pat-s
Copy link
Contributor

pat-s commented Jul 6, 2024

Can confirm, had a static agent with workloads for amd64 and the autoscaler with a filter for arm64. The latter only kicked in once the static agent was removed.

@xoxys xoxys mentioned this issue Jul 21, 2024
@anbraten anbraten changed the title Ignore static agents that are not sufficient for pending workload Ignore agents that are not sufficient for pending workload Jul 22, 2024
@anbraten
Copy link
Member

From #172:

e.g. don't count an running x86 agent arm64 etc ...

It would be nice if the autoscaler could scale up even if there is already an agent running but the current agent does not match labels in the queue but the autoscaler passed labels to create an agent would match ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhance existing feature
Projects
None yet
Development

No branches or pull requests

3 participants