Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo list allow to open in new tab #1259

Closed
6543 opened this issue Oct 13, 2022 · 5 comments · Fixed by #2378
Closed

repo list allow to open in new tab #1259

6543 opened this issue Oct 13, 2022 · 5 comments · Fixed by #2378
Labels
good first issue Likely to be an easy fix ui frontend related ux user experience

Comments

@6543
Copy link
Member

6543 commented Oct 13, 2022

repo list should also be as able as build list to open in a new tab

@6543 6543 added ui frontend related good first issue Likely to be an easy fix ux user experience labels Oct 13, 2022
@6543 6543 added this to the 1.0.0 milestone Oct 13, 2022
@CypherpunkSamurai
Copy link

Hello @6543,

I would like to contribute to this issue. How can i get started? :)

@6543
Copy link
Member Author

6543 commented Oct 18, 2022

@CypherpunkSamurai 👋

https://woodpecker-ci.org/docs/next/development/ui

all the next docu about development is interesting in this case ... but especialy the UI part

@janydoe
Copy link
Contributor

janydoe commented Mar 10, 2023

repo list should also be as able as build list to open in a new tab

Could you please clarify the issue? We can use the middle mouse click to open an build, a repository in a new tab. This is a standard and intuitive way to open a link in a new tab.

@hay-kot
Copy link
Contributor

hay-kot commented Mar 10, 2023

Could you please clarify the issue?

The element that is the link is rendered as a button element and not a a element. This is incorrect HTML semantics and reduces accessibility. You can still use middle click because it still triggers the on-click action and programmatically navigates to the page.

This PR fixes the issue though

@janydoe
Copy link
Contributor

janydoe commented Mar 11, 2023

The element that is the link is rendered as a button element and not a a element.

I agree if you are talking about an add repository button, for example. If this list of repositories is what @6543 meant, thank you for clarifying the task)

@anbraten anbraten removed this from the 1.0.0 milestone May 30, 2023
xoxys added a commit that referenced this issue Sep 8, 2023
Fixes: #1259

Work from https://github.com/woodpecker-ci/woodpecker/pull/1602/files

With this approach, existing buttons are still working and buttons with
`to="https://..."` are rendered as `a` tag. Not sure about the
"recursive render" issue from the original PR, have not seen any
rendering issue, any idea about this?


![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/2e87be21-3d3d-47b3-a2c4-1ffe5cfee592)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Likely to be an easy fix ui frontend related ux user experience
Projects
None yet
5 participants