Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide separate commit-title and commit-message in pipeline metadata #2359

Closed
xoxys opened this issue Aug 30, 2023 · 7 comments
Closed

Provide separate commit-title and commit-message in pipeline metadata #2359

xoxys opened this issue Aug 30, 2023 · 7 comments

Comments

@xoxys
Copy link
Member

xoxys commented Aug 30, 2023

We should expose commit-title and commit-message as dedicated metadata on the server-side because sometimes the title is more useful/readable instead of the full message e.g. in notification plugins or web UI.

posted by @xoxys in #2356 (comment)

@anbraten
Copy link
Member

What if we just leave new lines in the commit messages. This way it would be quite easy for the different places to decide if they just want to show the first line or more.

@xoxys
Copy link
Member Author

xoxys commented Aug 30, 2023

Sure, I thought it might be more handy for users this way, and it's done just once on the server-side. As a plugin author I can deal with newlines as well and for the Web UI we can of course also handle this easily. Feel free to close.

@anbraten
Copy link
Member

I think the issue is however that the commit message is a one-liner atm?

@qwerty287
Copy link
Contributor

Not in DB, but in UI it's shown without newlines (but the data is available)

@anbraten
Copy link
Member

In that case we could just show the first line normally and on hover the full message with new-lines

@xoxys
Copy link
Member Author

xoxys commented Aug 30, 2023

This issue was intended to be unrelated to the Web UI PR. The Web UI "issue" can be of course improved easily.

@qwerty287
Copy link
Contributor

I think we can close this (see #2359 (comment))?

qwerty287 added a commit that referenced this issue Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants