Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair not using value from WOODPECKER_WEBHOOK_HOST #2371

Closed
5 tasks done
math3vz opened this issue Sep 5, 2023 · 0 comments · Fixed by #2372
Closed
5 tasks done

Repair not using value from WOODPECKER_WEBHOOK_HOST #2371

math3vz opened this issue Sep 5, 2023 · 0 comments · Fixed by #2372
Labels
bug Something isn't working
Milestone
1.0.3

Comments

@math3vz
Copy link
Contributor

math3vz commented Sep 5, 2023

Component

server

Describe the bug

The repair function is recreating the webhoook using the WOODPECKER_HOST instead of WOODPECKER_WEBHOOK_HOST.

System Info

1.0-90310de6f1

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@math3vz math3vz added the bug Something isn't working label Sep 5, 2023
@math3vz math3vz mentioned this issue Sep 5, 2023
Merged
lafriks pushed a commit that referenced this issue Sep 6, 2023
@math3vz
fix(server/api/repo): Fix repair webhook host (#2372)
85e157b 
Fixes #2371

Similar change to
https://github.com/woodpecker-ci/woodpecker/pull/1869/files#diff-3cd73db84155aa0447a17dadc8f50271d646fcf6132606cf2ab703cc7b80eb38R113
This was referenced Sep 12, 2023
Closed
Merged
@qwerty287 qwerty287 added this to the 1.0.3 milestone Sep 13, 2023
qwerty287 added a commit that referenced this issue Sep 13, 2023
@math3vz @qwerty287
fix(server/api/repo): Fix repair webhook host (#2372) (#2452)
010da2e 
Backports #2372 to release 1.0

Fixes #2371

Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0.3
Development

Successfully merging a pull request may close this issue.

fix(server/api/repo): Fix repair webhook host math3vz/woodpecker
2 participants
@math3vz @qwerty287