Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI overflow on pipeline errors #2947

Closed
5 tasks done
xoxys opened this issue Dec 14, 2023 · 0 comments · Fixed by #2957
Closed
5 tasks done

UI overflow on pipeline errors #2947

xoxys opened this issue Dec 14, 2023 · 0 comments · Fixed by #2957
Labels
bug Something isn't working ui frontend related

Comments

@xoxys
Copy link
Member

xoxys commented Dec 14, 2023

Component

web-ui

Describe the bug

We should enforce line-breaks for the error text.

image

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"next-6de5922408"}

Additional context

No response

Validations

  • Read the Contributing Guidelines.
  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
  • Check that this is a concrete bug. For Q&A join our Discord Chat Server or the Matrix room.
@xoxys xoxys added bug Something isn't working ui frontend related labels Dec 14, 2023
@xoxys xoxys mentioned this issue Dec 16, 2023
Merged
lafriks pushed a commit that referenced this issue Dec 16, 2023
@xoxys
Fix error container overflow (#2957)
57790e4 
Fixes: #2947


![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/03198aec-fd3c-4fcd-8418-a7c5b0ff9d0b)

On the mobile view, it now wraps to show error on top. That is still not
perfect as it creates content jumps, after clicking on a pipeline with
errors. I don't have a better idea yet, but IMO it's already an
improvement as before it was quite unusable on mobile view.

Before:

![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/20849de8-55d6-4839-b4b4-fe220003887d)

After:

![image](https://github.com/woodpecker-ci/woodpecker/assets/3391958/8a80939b-d6a5-414d-b693-ef4583e2f37d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ui frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix error container overflow woodpecker-ci/woodpecker
1 participant
@xoxys