Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pod Annotations is missing on 2.2.2 #3254

Closed
3 tasks done
eliasscosta opened this issue Jan 22, 2024 · 1 comment
Closed
3 tasks done

Pod Annotations is missing on 2.2.2 #3254

eliasscosta opened this issue Jan 22, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@eliasscosta
Copy link
Contributor

Component

server, agent

Describe the bug

When variable WOODPECKER_BACKEND_K8S_POD_ANNOTATIONS is filled up with some annotations it doesn't pass to the pod anymore.

I think this code is related to the bug.
https://github.com/woodpecker-ci/woodpecker/blob/main/pipeline/backend/kubernetes/kubernetes.go#L166C4-L166C18

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.2.2"}

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@eliasscosta eliasscosta added the bug Something isn't working label Jan 22, 2024
6543 pushed a commit that referenced this issue Jan 22, 2024
Fix Issue: #3254

Co-authored-by: elias.souza <elias.souza@quintoandar.com.br>
@eliasscosta
Copy link
Contributor Author

The #3255 resolves the issue.

fernandrone pushed a commit to quintoandar/woodpecker that referenced this issue Feb 1, 2024
Fix Issue: woodpecker-ci#3254

Co-authored-by: elias.souza <elias.souza@quintoandar.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant