Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config service broken with 2.4.x #3528

Closed
3 tasks done
Sebclem opened this issue Mar 21, 2024 · 4 comments · Fixed by #3534
Closed
3 tasks done

Config service broken with 2.4.x #3528

Sebclem opened this issue Mar 21, 2024 · 4 comments · Fixed by #3534
Labels
bug Something isn't working
Milestone

Comments

@Sebclem
Copy link

Sebclem commented Mar 21, 2024

Component

server, agent

Describe the bug

Since update to 2.4.x, my config service as stopped working, this is my setup:
In my app repo, my .woodpecker.yml contain only this:

extend: https://mygiteahostname/sebclem/woodpecker-pipeline-config/raw/branch/main/playbook.yml

then i have setup a config service with WOODPECKER_CONFIG_SERVICE_ENDPOINT, this is the response form my service:

{
	"configs": [
		{
			"name": "playbook.yml",
			"data": "steps:\n  check-ansible-syntax:\n    image: xxxxxxxxx/sebclem/woodpecker-ansible-runner\n    pull: true\n    settings:\n      playbook: playbooks/install.yml\n      galaxy_file: roles/requirements.yml\n      check_syntax: true\n      vault_token:\n        from_secret: ansible_vault_token\n    when:\n      - event: \"push\"\n        branch: [main, master]\n      - event: [pull_request, manual, deployment]\n\n  run-ansible-playbook:\n    image: xxxxxxxxx/sebclem/woodpecker-ansible-runner\n    pull: true\n    settings:\n      verbosity: ${verbosity=0}\n      limit: ${limit}\n      tags: ${tags}\n      playbook: playbooks/install.yml\n      galaxy_file: roles/requirements.yml\n      vault_token:\n        from_secret: ansible_vault_token\n      private_key:\n        from_secret: ansible_private_key\n    when:\n      environment: production\n      event: deployment\n\nwhen:\n  - event: \"push\"\n    branch: [main, master]\n  - event: [pull_request, manual, deployment]\n"
		}
	]
}

Here the better formatted yml response:

steps:
  check-ansible-syntax:
    image: xxxxxxxxx/sebclem/woodpecker-ansible-runner
    pull: true
    settings:
      playbook: playbooks/install.yml
      galaxy_file: roles/requirements.yml
      check_syntax: true
      vault_token:
        from_secret: ansible_vault_token
    when:
      - event: \"push\"
        branch: [main, master]
      - event: [pull_request, manual, deployment]

  run-ansible-playbook:
    image: xxxxxxxxx/sebclem/woodpecker-ansible-runner
    pull: true
    settings:
      verbosity: ${verbosity=0}
      limit: ${limit}
      tags: ${tags}
      playbook: playbooks/install.yml
      galaxy_file: roles/requirements.yml
      vault_token:
        from_secret: ansible_vault_token
      private_key:
        from_secret: ansible_private_key
    when:
      environment: production
      event: deployment

when:
  - event: \"push\"
    branch: [main, master]
  - event: [pull_request, manual, deployment]

But since 2.4.x, I got those errors:
image

This worked well before updating.

System Info

{"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.4.1"}

Additional context

No response

Validations

  • Read the docs.
  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]
@Sebclem Sebclem added the bug Something isn't working label Mar 21, 2024
@Sebclem
Copy link
Author

Sebclem commented Mar 21, 2024

I can confirm that rolling back to 2.3.0 make it work again

@Sebclem
Copy link
Author

Sebclem commented Mar 21, 2024

My config service can be found here: https://git.sebclem.fr/sebclem/woodpecker-config-service
The docker is here if you need to reproduce this issue: https://git.sebclem.fr/sebclem/-/packages/container/woodpecker-config-service/latest

@qwerty287 qwerty287 added this to the 2.5.0 milestone Mar 21, 2024
anbraten pushed a commit that referenced this issue Mar 21, 2024
and remove two unused flags

should close #3528
@anbraten
Copy link
Member

@Sebclem Could you test if #3534 (latest next version) solves your issue.

@Sebclem
Copy link
Author

Sebclem commented Mar 22, 2024

@Sebclem Could you test if #3534 (latest next version) solves your issue.

Yes, it's working with next
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants