Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status messages for protected pipelines #895

Closed
3 tasks done
qwerty287 opened this issue Apr 29, 2022 · 1 comment · Fixed by #2757
Closed
3 tasks done

Improve status messages for protected pipelines #895

qwerty287 opened this issue Apr 29, 2022 · 1 comment · Fixed by #2757
Labels
enhancement improve existing features

Comments

@qwerty287
Copy link
Contributor

Clear and concise description of the problem

Currently, the status sent back to the forge looks like this:

state status message
pipeline waits for approval pending Pipeline is pending
pipeline is declined pending Pipeline is pending

Suggested solution

It should look like:

state status message
pipeline waits for approval pending Pipeline waits for approval
pipeline is declined failed Pipeline was declined

Alternative

No response

Additional context

No response

Validations

@xoxys

This comment was marked as off-topic.

qwerty287 added a commit that referenced this issue Feb 22, 2024
This stores workflows and steps to DB even if it is not yet approved and
thus blocked.

I'm not really happy with this, because even though it is stored, it
must parse the pipeline again and set back the original UUID. If you
have any ideas how to fix/improve this just comment.

In addition, this allows to view step list and side panel for approved
pipelines, #2345 is
partially not longer necessary.

Closes #895

---------

Co-authored-by: 6543 <6543@obermui.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants