Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option for docker runtime to provide default volumes #1203

Merged
merged 4 commits into from Sep 26, 2022

Conversation

lafriks
Copy link
Contributor

@lafriks lafriks commented Sep 25, 2022

Fixes #993

Not tested yet, will test once PR docker image is built Tested and works just fine 😊

@woodpecker-bot
Copy link
Collaborator

woodpecker-bot commented Sep 26, 2022

Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-1203.surge.sh

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 49.38% // Head: 49.38% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3680fd9) compared to base (ec9b0a6).
Patch has no changes to coverable lines.

❗ Current head 3680fd9 differs from pull request most recent head 957e864. Consider uploading reports for the commit 957e864 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1203   +/-   ##
=======================================
  Coverage   49.38%   49.38%           
=======================================
  Files          88       88           
  Lines        6624     6615    -9     
=======================================
- Hits         3271     3267    -4     
+ Misses       3158     3153    -5     
  Partials      195      195           
Impacted Files Coverage Δ
server/shared/procBuilder.go 84.61% <0.00%> (-0.52%) ⬇️
server/logging/log.go 54.65% <0.00%> (+5.81%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lafriks
Copy link
Contributor Author

lafriks commented Sep 26, 2022

Tested and confirm working

@anbraten anbraten enabled auto-merge (squash) September 26, 2022 14:25
@anbraten anbraten merged commit 2e08dd2 into woodpecker-ci:master Sep 26, 2022
@6543 6543 added enhancement improve existing features backend/docker labels Sep 26, 2022
@6543 6543 added this to the 1.0.0 milestone Sep 26, 2022
@6543 6543 deleted the feat/default_docker_binds branch September 26, 2022 15:07
@6543
Copy link
Member

6543 commented Sep 26, 2022

please don't forget to add labels !!!

@anbraten
Copy link
Member

In case the variable is not set this wont allow to run pipelines anymore: Error response from daemon: invalid volume specification: ''

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend/docker enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow volumes to be mounted for all plugin containers
6 participants