Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove undocumented docker specific option #1825

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 5, 2023

No description provided.

@6543 6543 added the refactor delete or replace old code label Jun 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.05 ⚠️

Comparison is base (ea895ba) 39.03% compared to head (d0c7062) 38.99%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1825      +/-   ##
==========================================
- Coverage   39.03%   38.99%   -0.05%     
==========================================
  Files         168      168              
  Lines       10502    10500       -2     
==========================================
- Hits         4099     4094       -5     
- Misses       6138     6141       +3     
  Partials      265      265              
Impacted Files Coverage Δ
pipeline/backend/docker/convert.go 8.66% <ø> (+0.06%) ⬆️
pipeline/frontend/yaml/compiler/convert.go 0.00% <ø> (ø)
pipeline/frontend/yaml/container.go 77.77% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@6543 6543 requested a review from a team June 5, 2023 10:26
@gapodo
Copy link
Contributor

gapodo commented Jun 5, 2023

Hi,

short note from my side, removin this will likely result in it being requested for readdition soon(tm), as esp. with K8s there is often a need to label containers for them to be able to run (depends on the k8s setup, but things like network restrictions,... are often applied via labels (or annotations)).

Though this could/should potentially be a seperate issue / rfc / FR as to how we handle backend specific options?

@6543
Copy link
Member Author

6543 commented Jun 5, 2023

well in that case it will be a k8s specific backend option yes

@6543
Copy link
Member Author

6543 commented Jun 5, 2023

@gapodo https://woodpecker-ci.org/docs/next/administration/backends/kubernetes#resources

@gapodo
Copy link
Contributor

gapodo commented Jun 5, 2023

@gapodo https://woodpecker-ci.org/docs/next/administration/backends/kubernetes#resources

Oh, thx, sorry had some troubles keeping up with all the changes... Since it's cared for by the new backend_options (where it should be implemented in that case), you can disregard my note.

@qwerty287 qwerty287 merged commit f81b447 into woodpecker-ci:master Jun 5, 2023
5 checks passed
@qwerty287 qwerty287 deleted the remove_docker-specific_undocumented_option branch June 5, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants