Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of UI #245

Merged
merged 192 commits into from
Nov 3, 2021
Merged

Rewrite of UI #245

merged 192 commits into from
Nov 3, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jul 17, 2021

closes #246
closes #229
closes #266
closes #203
closes #191

Idea

Rewrite of the UI using Typescript, Vue3, Windicss (similar to Tailwind) and Vite. The design should be close to the current one with some changes:

  • latest pipeline in a sidebar on the right
  • secrets and registry as part of the repo-settings (secrets and registry entries shouldn't be used as much so they can be "hidden" under settings IMO)
  • start page shows list of active repositories with button to enable / add new ones (currently you see all repositories and in most cases you only add new repositories once in a while)

TODO

  • authentication
    • login
    • logout
    • login error page
    • handle token errors and re-login (an expired token will be removed by server, so no need to handle it by hand)
  • own repo list
    • show active repos
    • show button to activate more repos
  • add new repo
    • list inactive & active repos
  • repo overview
    • show builds
    • show current build status (badge)
    • link vcs
    • show list of active branches
  • build details
    • show jobs
    • show job logs
    • show details (since, duration)
    • link commit
    • build actions (cancel / re-start pipeline)
    • approve / decline pipeline
    • show artifacts and download links
  • repo settings
    • secrets
    • registry
    • delete / deactivate repo
    • general settings
  • user settings
    • show own token / cli setup
  • layout
    • build-feed (right sidebar)
      • open / close
      • improve item view
      • listen to updates
      • add search to filter by repo, commit message
    • navbar
      • show amount of currently active & pending pipelines (click on it to open / close sidebar)
  • permissions
    • show login button if not authenticated
    • don't show hidden repos (redirect if access)
    • don't show buttons / views if missing permissions
      • settings
      • hide active jobs & sidebar if not authenticated
      • build actions (restart, cancel, ...)
  • ci (add some new ci jobs)
    • check format with prettier
    • check linting
    • check types
  • misc
    • link docs
    • show current version
    • icons
    • confirm dialogs
    • add toast for every save / await call
    • support emojis in commit-messages
    • handle errors and toast them
    • add some eslint config
    • allow to set docs url again
    • fix tabs
    • check color contrasts
    • running gif need transparent background
    • increment time of running builds
    • show no builds in sidebar if empty
    • only show "own" repos in repo-add and repo-list (repos you have at least push access to) Fix repo access #476
    • add search for repo list

Before merging

This PR includes some changes introduced by following PRs. So they have to be merged before this one gets merged.

Follow Ups

  • remove WithDocs
  • remove template execution for index.html => simply serve static file

Screenshots

Peek 2021-10-26 22-34

Screenshot from 2021-09-19 00-17-24
Screenshot from 2021-09-19 00-16-46
Screenshot from 2021-09-19 00-16-26

Screenshot from 2021-09-19 21-52-55

@6543

This comment has been minimized.

@anbraten

This comment has been minimized.

@anbraten anbraten changed the title feat(web): replace webpack with vite feat(web): rewrite of web-interface Jul 19, 2021
@anbraten anbraten mentioned this pull request Jul 21, 2021
@6543

This comment has been minimized.

@anbraten

This comment has been minimized.

@anbraten anbraten marked this pull request as ready for review October 30, 2021 02:32
@anbraten anbraten requested a review from 6543 October 30, 2021 02:32
@anbraten anbraten removed the wip label Oct 30, 2021
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could not find any issue in the code and it looks amazing.

I think there are 1-2... bugs/issues still hidden somewhere but that can be fixed in followups.
This do really bring things forward and fix a lot :)

@6543 6543 enabled auto-merge (squash) November 3, 2021 13:49
@davidak
Copy link
Contributor

davidak commented Nov 3, 2021

@6543 one check failed https://wp.laszlo.cloud/woodpecker-ci/woodpecker/1079/14

@6543 6543 merged commit 58838f2 into woodpecker-ci:master Nov 3, 2021
@davidak
Copy link
Contributor

davidak commented Nov 4, 2021

Great work. Thank you @anbraten!

@anbraten anbraten deleted the vite branch November 4, 2021 08:45
@6543
Copy link
Member

6543 commented Nov 4, 2021

forward thanks to @anbraten ;)

@davidak
Copy link
Contributor

davidak commented Nov 4, 2021

@6543 ah, sure. you only merged it

@woodpecker-ci woodpecker-ci locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature add new functionality refactor delete or replace old code ui frontend related
Projects
None yet
5 participants