Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make config linking non-unique #3128

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

qwerty287
Copy link
Contributor

closes #3093

@qwerty287 qwerty287 added bug Something isn't working server labels Jan 7, 2024
@qwerty287 qwerty287 added this to the 2.2.0 milestone Jan 7, 2024
@qwerty287 qwerty287 requested a review from a team January 7, 2024 14:49
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (d815b20) 34.82% compared to head (7bc950a) 34.87%.
Report is 13 commits behind head on main.

Files Patch % Lines
pipeline/backend/kubernetes/kubernetes.go 0.00% 11 Missing ⚠️
pipeline/backend/kubernetes/pod.go 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   34.82%   34.87%   +0.04%     
==========================================
  Files         228      228              
  Lines       14755    14772      +17     
==========================================
+ Hits         5139     5152      +13     
- Misses       9238     9242       +4     
  Partials      378      378              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qwerty287 qwerty287 merged commit 106508a into woodpecker-ci:main Jan 7, 2024
8 checks passed
@qwerty287 qwerty287 deleted the no-uniq branch January 7, 2024 15:12
@woodpecker-bot woodpecker-bot mentioned this pull request Jan 8, 2024
1 task
@6543
Copy link
Member

6543 commented Jan 9, 2024

we should not do that ... this is a hotfix at most!!

@qwerty287 could you check why the dublication did ocured in the first place.

or at lesat add a dedicated pipelineConfigID and retrive it based on that.

this table is just for n-m relation mapping and such should never have a dublicate!!!

@qwerty287
Copy link
Contributor Author

Well, I know that this shouldn't occur, but in this case, it was 100% expected.

Just add two yaml files with exactly the same content (yes, I know this isn't a common use case).

This triggers the unique constraints and fails, but I think it should work without issues.

6543 added a commit to 6543-forks/woodpecker that referenced this pull request Jan 13, 2024
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Jan 18, 2024
@6543
Copy link
Member

6543 commented Jan 18, 2024

I found the root cause

so i created a fix and add tests for that #3215

lafriks pushed a commit that referenced this pull request Jan 18, 2024
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
fernandrone pushed a commit to quintoandar/woodpecker that referenced this pull request Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when adding two equal workflow configs
3 participants