Refactor: Create agent/ package for backend agnostic logic #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copart-jafloyd
force-pushed
the
agent-package
branch
2 times, most recently
from
3f5fcce
to
1468b81
Compare
copart-jafloyd
force-pushed
the
agent-package
branch
from
1468b81
to
0fca175
Compare
anbraten
reviewed
Sep 22, 2021
anbraten
approved these changes
Sep 22, 2021
6543
reviewed
Sep 23, 2021
6543
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm reviewing what it takes to add a new backend (eg for kubernetes).
This is a little bit of the refactoring based on what I saw in the kube branch, but without any reference to kubernetes.
Unlike the kube branch, I called the package
agent/instead ofrunner/. That fits the pattern of keeping server related stuff underserver/, cli related stuff undercli/, and now agent-related stuff underagent/.For reference, see these commits:
7f4a0c8 Factor into Runner
f7fe9ed Using Runner in server