Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Code #348

Merged
merged 16 commits into from
Sep 24, 2021
Merged

Cleanup Code #348

merged 16 commits into from
Sep 24, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 24, 2021 •
edited

  • Fix "Empty slice declaration using a literal"
  • Fix "collides with imported package name"
  • Remove unused code in pipeline
  • Remove unused oauth2.providerAuthHeaderWorks()
  • Add TODOs
  • Format Code
  • Cleanup doublestar import
  • Migrate deprecated functions

@6543 6543 added the refactor delete or replace old code label Sep 24, 2021
@6543 6543 added this to the 0.15.0 milestone Sep 24, 2021
@6543 6543 changed the title [WIP] Cleanup Code Cleanup Code Sep 24, 2021
@6543 6543 requested a review from anbraten September 24, 2021 12:50
anbraten
anbraten reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we introduce some kind of linter like golangci to automatically check most of your changes.

cmd/server/server.go Outdated Show resolved Hide resolved
pipeline/frontend/yaml/constraint.go Show resolved Hide resolved
server/api/hook.go Show resolved Hide resolved
server/shared/configFetcher.go Outdated Show resolved Hide resolved
6543 and others added 2 commits September 24, 2021 15:57
@6543 6543 requested a review from anbraten September 24, 2021 13:57
@anbraten anbraten merged commit 0bd10fa into woodpecker-ci:master Sep 24, 2021
@6543 6543 deleted the cleanup branch September 24, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@6543 @anbraten