Ability to set pod annotations and labels from step #3609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-s
reviewed
Apr 16, 2024
|
@qwerty287, maybe build images here too and @dominic-p could test? |
qwerty287
added
the
build_pr_images
|
Thanks for the work on this @zc-devs! I'm ready to test as soon as the pipelines run. It looks like they are pending approval at the moment. |
|
This one is ready |
|
Ok, I was able to test this tonight, and it's working as expected for me! If you would like, I can take a stab at a PR for the docs. Just let me know. |
It would be great! Thanks in advance. |
dominic-p
added a commit
to dominic-p/woodpecker
that referenced
this pull request
May 6, 2024
|
@qwerty287, seems, we are ready for merge here and there. |
qwerty287
reviewed
May 9, 2024
qwerty287
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3188