Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: move model/ to server/model/ #366

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Refactor: move model/ to server/model/ #366

merged 2 commits into from
Sep 27, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 27, 2021

No description provided.

@6543 6543 added the refactor delete or replace old code label Sep 27, 2021
@6543 6543 added this to the 0.15.0 milestone Sep 27, 2021
@anbraten
Copy link
Member

Shouldn't we try to replace drone-go types with models and therefore leave the models at some central point?

@6543
Copy link
Member Author

6543 commented Sep 27, 2021 •
edited

the drone-go is the rest sdk and I think we should differ between database backend and rest api structs

@6543 6543 merged commit a94807e into woodpecker-ci:master Sep 27, 2021
@6543 6543 deleted the refactor_move-models branch September 27, 2021 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@6543 @anbraten