Clarify info on failing workflows/Steps #3679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zc-devs
reviewed
May 4, 2024
Co-authored-by: Thomas Anderson <127358482+zc-devs@users.noreply.github.com>
xoxys
reviewed
May 4, 2024
|
@Andre601 can you check it again? |
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
Done. Checked on mobile and there you can't commit suggestions :/ |
xoxys
approved these changes
May 5, 2024
|
Looks like some CI runs encounter propblems (pr/docs seems to have a 403 error). |
|
Deployment of preview was successful: https://woodpecker-ci-woodpecker-pr-3679.surge.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I felt like the info at the start of the workflow syntax page was a bit misleading.
It mentioned that a failed step cancels the full workflow, not mentioning that steps with a
status: [failed]will actually execute under such circumstances.I've replaced that part with a
:::noteblock, informing about this special case, while also linking to the option itself.Hope this is a good change.