Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass context.Context down #371

Merged
merged 13 commits into from
Sep 28, 2021
Merged

Pass context.Context down #371

merged 13 commits into from
Sep 28, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Sep 28, 2021

this will make it possible to cancel requests for top and trace processes ...

Guide: https://golangbyexample.com/using-context-in-golang-complete-guide/
Ref: https://pkg.go.dev/context

@6543 6543 added enhancement improve existing features refactor delete or replace old code labels Sep 28, 2021
@6543 6543 added this to the 0.15.0 milestone Sep 28, 2021
@6543 6543 requested a review from anbraten September 28, 2021 02:28
server/remote/bitbucketserver/internal/client.go Outdated Show resolved Hide resolved
server/remote/coding/coding.go Outdated Show resolved Hide resolved
server/remote/gitlab3/gitlab_test.go Show resolved Hide resolved
server/shared/configFetcher.go Outdated Show resolved Hide resolved
6543 and others added 4 commits September 28, 2021 12:33
@6543
Copy link
Member Author

6543 commented Sep 28, 2021

for gitlab3 see #358 it will be removed ...
for gitlab I did not pass it down since I would have to extend the custom client just to throw that change after #358 got merged

so if #358 lands first I'll add it here else it's the other way arround

@anbraten anbraten merged commit e3499f6 into woodpecker-ci:master Sep 28, 2021
@6543 6543 deleted the context branch September 28, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features refactor delete or replace old code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants