Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace DRONE_ with CI_ variables in pipeline steps #427

Merged
merged 19 commits into from
Nov 25, 2021
Merged

Replace DRONE_ with CI_ variables in pipeline steps #427

merged 19 commits into from
Nov 25, 2021

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Oct 10, 2021 •
edited

Changes

Dropped support for DRONE_* environment variables in pipeline steps. Pipeline meta-data can be accessed with CI_* variables.

  • CI_* prefix replaces DRONE_*
  • CI value is now woodpecker
  • DRONE=true has been removed

Follow ups

  • add CI_AGENT_* variables
  • improve agent (cli exec) arch detection
  • improve tracer environment updating

@anbraten anbraten added refactor delete or replace old code breaking will break existing installations if no manual action happens labels Oct 10, 2021
@anbraten anbraten added this to the 0.15.0 milestone Oct 10, 2021
@anbraten anbraten self-assigned this Oct 10, 2021
@anbraten anbraten marked this pull request as draft October 10, 2021 07:41
@anbraten anbraten mentioned this pull request Oct 10, 2021
Closed
15 tasks
6543
6543 reviewed Oct 10, 2021
View reviewed changes
cli/exec/flags.go Outdated Show resolved Hide resolved
6543
6543 reviewed Oct 10, 2021
View reviewed changes
agent/runner.go Show resolved Hide resolved
6543
6543 reviewed Oct 10, 2021
View reviewed changes
Makefile Show resolved Hide resolved
6543
6543 reviewed Nov 14, 2021
View reviewed changes
pipeline/frontend/metadata.go Outdated Show resolved Hide resolved
@anbraten anbraten marked this pull request as ready for review November 14, 2021 21:50
@anbraten anbraten requested a review from 6543 November 14, 2021 21:51
@6543 6543 self-requested a review November 24, 2021 00:37
6543
6543 approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well yes move on :)

@6543 6543 merged commit 063d0bb into woodpecker-ci:master Nov 25, 2021
@anbraten anbraten deleted the ci-env-vars branch November 25, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@6543 6543 6543 approved these changes

Assignees

@anbraten anbraten

Labels
breaking will break existing installations if no manual action happens refactor delete or replace old code
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anbraten @6543