Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some wrapper and make code more redable #478

Merged
merged 6 commits into from
Oct 28, 2021
Merged

Remove some wrapper and make code more redable #478

merged 6 commits into from
Oct 28, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Oct 26, 2021

  • meaningful var names
  • no context wrapper, use store directly
  • retrieve store from context once
  • rm store.GetRepoOwnerName

@6543
refactor store functions:
7397672 
* meaningfull var names
* no context wrapper, use store directly
@6543
retrieve store from context once
a931e7e
@6543
rm GetRepoOwnerName
5c293d3
@6543 6543 added the refactor delete or replace old code label Oct 26, 2021
@6543 6543 added this to the 0.15.0 milestone Oct 26, 2021
@6543 6543 changed the title remove some wrapper and make code more redable Remove some wrapper and make code more redable Oct 26, 2021
@6543 6543 added the server label Oct 26, 2021
@6543 6543 requested a review from anbraten October 27, 2021 19:31
@6543 6543 enabled auto-merge (squash) October 28, 2021 09:09
@6543 6543 merged commit 965235e into woodpecker-ci:master Oct 28, 2021
@6543 6543 deleted the rm-some-wrapper branch October 28, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
refactor delete or replace old code server
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@6543 @anbraten