Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero steps #52

Merged
merged 4 commits into from
Jul 20, 2019
Merged

Zero steps #52

merged 4 commits into from
Jul 20, 2019

Conversation

laszlocph
Copy link
Member

@laszlocph laszlocph commented Jul 19, 2019

With skip_clone: true introduced, there are cases where there are no pipeline steps to run.

Clone always ran in the past, now if we skip clone and the pipeline steps have branch/event conditions preventing steps from running, we can have cases where there are no steps to run. This is breaking the UI and the scheduler too.

This PR handles two cases:

  • when a pipeline in multi-pipeline setup have no steps to run, that pipeline is not created at all
  • in a single pipeline setup if there are no steps to run, the pipeline is not triggered at all, leaving no sign of the webhook in Drone, except informing the webhook sender about this special case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant