Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show environ in every BuildProc #526

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Show environ in every BuildProc #526

merged 4 commits into from
Nov 23, 2021

Conversation

catdevnull
Copy link
Contributor

@catdevnull catdevnull commented Nov 22, 2021 •
edited by anbraten

Screenshot from 2021-11-22 21-16-14
Screenshot from 2021-11-22 21-16-02

@catdevnull catdevnull mentioned this pull request Nov 22, 2021
Closed
13 tasks
@6543 6543 added the ui frontend related label Nov 22, 2021
@6543 6543 added this to the 0.15.0 milestone Nov 22, 2021
@anbraten
Copy link
Member

@catdevnull I have updated it a bit for you. What do you think?

@anbraten anbraten added the enhancement improve existing features label Nov 22, 2021
@catdevnull
Copy link
Contributor Author

Yes, this is so much better. I didn't know what to go off by because there's no design, and I used Object.entries because I didn't know the Vue-specific syntax. Shouldn't the build error considering that I didn't add environ to the TypeScript definition? Either way +1

@6543 6543 merged commit 34ff300 into woodpecker-ci:master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
enhancement improve existing features ui frontend related
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@catdevnull @anbraten @6543