Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve status updates #561

Merged
merged 28 commits into from
Dec 28, 2021
Merged

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Dec 1, 2021

closes #410
closes #297
closes #459
closes #521

Changes

  • link to specific proc (only general build before)
  • set status for all procs (before: only for the whole build on some SCMs)
  • set status after restart
  • set status to pending after waiting for approval
  • make status of gitlab, gitea & github equal
  • dedupe status update code
  • dedupe PostBuild code

Tests

  • Gitea: restart build
  • Gitea: push to branch
  • Gitea: push to PR
  • Gitea: multi-file pipeline
  • Gitea: single file pipeline
  • Gitea: matrix pipeline
  • Gitlab: push to PR
  • Gitlab: push to branch
  • Github: push to branch
  • Github: push to PR

@anbraten anbraten added the enhancement improve existing features label Dec 1, 2021
@anbraten anbraten self-assigned this Dec 1, 2021
@6543 6543 added the forge/gitea gitea forge related label Dec 1, 2021
@6543
Copy link
Member

6543 commented Dec 1, 2021

I'd like to move context generation out of remotes if possible ... (so only one func for all remotes)

@6543
Copy link
Member

6543 commented Dec 1, 2021

-> #410

@anbraten anbraten changed the title report gitea proc status back similar to github Improve status updates Dec 12, 2021
@6543 6543 added this to the 0.15.0 milestone Dec 17, 2021
@anbraten anbraten added bug Something isn't working and removed forge/gitea gitea forge related labels Dec 18, 2021
server/api/hook.go Outdated Show resolved Hide resolved
server/api/build.go Outdated Show resolved Hide resolved
@anbraten anbraten marked this pull request as ready for review December 22, 2021 00:06
@anbraten
Copy link
Member Author

Okay done with the status updates. Only thing left is the way how we handle status of matrix build as atm it will not seperate status per matrix, but I would do that in a separate PR as this one already has quite some change.

@anbraten anbraten requested a review from 6543 December 22, 2021 00:22
@6543 6543 merged commit 8e8f896 into woodpecker-ci:master Dec 28, 2021
@anbraten anbraten deleted the gitea-status-procs branch December 28, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement improve existing features
Projects
None yet
2 participants