Fix gRPC incomapatability in helm chart #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
approved these changes
Dec 19, 2021
BracketJohn
deleted the
fix_grpc_incompatability_docker_in_docker_backend
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #600
I investigated the issue: The underlying issue was that the docker-in-docker (dind) image specified by the helm chart is >2 years old and thus is incompatible with gRPC v1.41 which the wooderpecker agent uses to communicate with it.
I tested the fix proposed in this PR in our AWS EKS cluster and it works, builds are being executed again (:
Looking forward to your review.