Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sqlite migration on column drop of abnormal schemas #629

Merged

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 19, 2021

since the function was originally written with the idea in mind, that sqlite schema is generated, it did not normalize stuff.

now we normalize table schema and use a custom method to obtain column names from schema

TODO:

  • fix stuff
  • unit tests

close #628

@6543 6543 added bug Something isn't working server labels Dec 19, 2021
@6543 6543 added this to the 0.15.0 milestone Dec 19, 2021
@6543 6543 marked this pull request as ready for review December 19, 2021 20:59
@6543 6543 changed the title sqlite migration edgecases fix sqlite migration on column drop of abnormal schemas Dec 19, 2021
@6543 6543 requested a review from a team December 19, 2021 21:09
@6543 6543 added the important label Dec 19, 2021
@anbraten anbraten merged commit b2ce1f5 into woodpecker-ci:master Dec 20, 2021
@6543 6543 deleted the store_fix-sqlite-migration-edgecases branch December 20, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working important server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlite migration drop table column not work
2 participants