Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proc.Tree() func should not depend on sorted procs list #647

Merged
merged 2 commits into from
Dec 31, 2021
Merged

proc.Tree() func should not depend on sorted procs list #647

merged 2 commits into from
Dec 31, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Dec 30, 2021 •
edited

close #645

@6543 6543 added this to the 0.15.0 milestone Dec 30, 2021
@6543 6543 added the bug Something isn't working label Dec 30, 2021
anbraten
anbraten approved these changes Dec 31, 2021
View reviewed changes
Copy link
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Could you add some tests for the this func?

@6543
Add test case
6c244b4 
Signed-off-by: 6543 <6543@obermui.de>
@6543 6543 merged commit 30c3e13 into woodpecker-ci:master Dec 31, 2021
@6543 6543 deleted the procs_do-not-depend-on-spe-proc-order branch December 31, 2021 16:43
@anbraten anbraten changed the title proc.Tree() func do not depend on sorted procs list proc.Tree() func should not depend on sorted procs list Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anbraten anbraten anbraten approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.15.0
Development

Successfully merging this pull request may close these issues.

Corrupted proc structure
2 participants
@6543 @anbraten