Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix gitlab sub repo listing #652

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

anbraten
Copy link
Member

@anbraten anbraten commented Jan 3, 2022

This fix allows us to list sub-repos from Gitlab, so users get a list of all gitlab repos and can activate "normal" repos.
Enabling / using sub-repos is not solved by this PR and will reult in an error for now.

close #651

@6543
Copy link
Member

6543 commented Jan 3, 2022

@jdoubleu can you check this works for you as hotfix?

@6543 6543 added bug Something isn't working forge/gitlab gitlab forge related labels Jan 3, 2022
@6543 6543 added this to the 0.15.0 milestone Jan 3, 2022
@jdoubleu
Copy link
Contributor

jdoubleu commented Jan 3, 2022

Yes, at least the sync looks like it's been working 👍

Are you sure, that's not breaking somewhere else, because you store the groups and subgroups in the owner path? On the other hand, I've only seen ... yet:

fmt.Sprintf("%s/%s", repo.Owner, repo.Name)

@6543
Copy link
Member

6543 commented Jan 3, 2022

can we have both?

-> #652 & #656

@jdoubleu
Copy link
Contributor

jdoubleu commented Jan 3, 2022

can we have both?

-> #652 & #656

As far as I understand, #652 makes #656 obsolete, because we can now properly handle nested repositories and no longer need to filter them out?

@6543
Copy link
Member

6543 commented Jan 3, 2022

@anbraten ☝️ your pull make it not fail - should we filter them until #648 Y/N

I'm for also filtering them ...

@anbraten
Copy link
Member Author

anbraten commented Jan 3, 2022

It kind of works. The listing is fine, but if you want to enable the repo, you get an 404 error as it tries to load /api/repo/group/sub-group/my-repo/activate, but the route is only listening under /api/repo/owner/my-repo/activate.

@anbraten
Copy link
Member Author

anbraten commented Jan 3, 2022

I would merge #652 (this PR) and #656 as well.

@6543 6543 merged commit 7e6765c into woodpecker-ci:master Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working forge/gitlab gitlab forge related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants