Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DOCKER_HOST env to search for docker before searching for a hardcode docker socket #763

Merged
merged 3 commits into from
Feb 8, 2022

Conversation

mscherer
Copy link
Contributor

@mscherer mscherer commented Feb 8, 2022

Fix #757

@mscherer
Copy link
Contributor Author

mscherer commented Feb 8, 2022

I haven't test the PR yet, might not have time before the weekend, so that's more a proposal.

@wxiaoguang
Copy link

The DOCKER_HOST could be a URL:

https://docs.docker.com/engine/security/protect-access/

$ export DOCKER_HOST=ssh://docker-user@host1.example.com
$ docker info

I think as long as the environment exists, we do not to check the existence again.

@mscherer mscherer force-pushed the do_not_hardcode_docker_socket branch from 076d656 to 71aa99b Compare February 8, 2022 14:44
@mscherer
Copy link
Contributor Author

mscherer commented Feb 8, 2022

Ok so more like this ?

@wxiaoguang
Copy link

Now it looks good 😊

@6543 6543 added the agent label Feb 8, 2022
@6543 6543 changed the title Do not hardcode docker socket Use DOCKER_HOST env to check for docker befor looking for hardcode docker socket Feb 8, 2022
@6543 6543 changed the title Use DOCKER_HOST env to check for docker befor looking for hardcode docker socket Use DOCKER_HOST env to search for Docker before searching for a hardcode Docker socket Feb 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #763 (a3125a0) into master (5f79739) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a3125a0 differs from pull request most recent head 43b9bda. Consider uploading reports for the commit 43b9bda to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #763   +/-   ##
=======================================
  Coverage   52.23%   52.23%           
=======================================
  Files          86       86           
  Lines        5940     5940           
=======================================
  Hits         3103     3103           
  Misses       2665     2665           
  Partials      172      172           
Impacted Files Coverage Δ
server/shared/procBuilder.go 86.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7521336...43b9bda. Read the comment docs.

@6543 6543 changed the title Use DOCKER_HOST env to search for Docker before searching for a hardcode Docker socket Use DOCKER_HOST env to search for docker before searching for a hardcode docker socket Feb 8, 2022
@6543 6543 added this to the 0.15.0 milestone Feb 8, 2022
@6543 6543 added the enhancement improve existing features label Feb 8, 2022
@6543 6543 enabled auto-merge (squash) February 8, 2022 22:38
@6543 6543 merged commit 3b52afa into woodpecker-ci:master Feb 8, 2022
inflatador added a commit to inflatador/woodpecker that referenced this pull request Feb 4, 2023
Document DOCKER_HOST environment variable as described at woodpecker-ci#763
6543 pushed a commit that referenced this pull request Feb 10, 2023
Document DOCKER_HOST environment variable as described at
#763
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent enhancement improve existing features skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to set custom path to Docker socket
4 participants