Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make path match users configurations #125

Closed
wants to merge 2 commits into from

Conversation

mlindner
Copy link

@mlindner mlindner commented May 4, 2024

By default homebrew always sets the system path up so that homebrew is before the system installs and /usr/local/bin installs. Without this it is possible to result in a configuration where the wrong mpv than the one the user expects is called.

By default homebrew always sets the system path up so that homebrew is before the system installs and /usr/local/bin installs. Without this it is possible to result in a configuration where the wrong mpv than the one the user expects is called.
Additionally modify python script's path to match the changes to the ruby script's path.
@mlindner mlindner mentioned this pull request May 4, 2024
@woodruffw
Copy link
Owner

Thank you for the patch! I just merged this, however: 4585f17..f57d39b

(This is still just a heuristic, since users can configure their systems in infinitely different ways. But it's better than our previous heuristic.)

@woodruffw woodruffw closed this May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants