Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paketPack task creation #2

Merged

Conversation

Larusso
Copy link
Member

@Larusso Larusso commented Jun 23, 2017

Create all paketPack tasks when applying the plugin so users can refer
to the generated tasks at configuration time.

Adjust test specs

fixes #1

create all `paketPack` tasks when applying the plugin so users can refer
to the generated tasks at configuration time.

Adjust test specs
@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-1.03%) to 83.489% when pulling d5cb933 on fix/issue-1-paket-pack-task-generated-after-evaluation into 6854af1 on master.

Add call `configurePaketInstallIfPresent` back to apply plugin method
Make the test more robust. It showed false positives.
@Larusso Larusso force-pushed the fix/issue-1-paket-pack-task-generated-after-evaluation branch from 945bb2f to b61c576 Compare June 23, 2017 08:56
@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-0.05%) to 84.472% when pulling b61c576 on fix/issue-1-paket-pack-task-generated-after-evaluation into 6854af1 on master.

@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-0.05%) to 84.472% when pulling b61c576 on fix/issue-1-paket-pack-task-generated-after-evaluation into 6854af1 on master.

@coveralls
Copy link

coveralls commented Jun 23, 2017

Coverage Status

Coverage decreased (-0.05%) to 84.472% when pulling a3e9fad on fix/issue-1-paket-pack-task-generated-after-evaluation into 6854af1 on master.

@Larusso Larusso merged commit 028f7a0 into master Jun 23, 2017
@Larusso Larusso deleted the fix/issue-1-paket-pack-task-generated-after-evaluation branch June 23, 2017 15:39
@ghost ghost added the atlas-stream label Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PaketPack Task generated after evaluation
3 participants