Add support for pubsub. #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Dave, Thanks for the patch! Did you see the discussion on #13 ? I think you have solved some of the issues quite elegantly, but I'm not ready to merge it just yet. I think we should have a clone of eredis_client that implements anything sub-related. In the issue mentioned above we discussed a few ideas for how we could use the subscriptions and this would be cleaner to implement in it's own module, than to add it on top of the normal client. With that said, I'm very happy about receiving the patch. Thanks for the good work! |
g-andrade
pushed a commit
to g-andrade/eredis
that referenced
this pull request
Jul 20, 2021
…pilation-path-issues Fix rebar3 -related (via certifi and code:.) compilation issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for redis pubsub (or just sub, since you could already pub).