Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for delete! with multiple ids #57

Open
BrandonEscamilla opened this issue Sep 6, 2023 · 3 comments
Open

Support for delete! with multiple ids #57

BrandonEscamilla opened this issue Sep 6, 2023 · 3 comments

Comments

@BrandonEscamilla
Copy link

Hi!

It would be great if we "delete!" could handle deleting multiple IDs, similar to how insert! works. Is it possible to implement this functionality? Thank you in advance!
@wookay wookay closed this as completed in 51d5046 Sep 7, 2023
@wookay wookay reopened this Sep 7, 2023
@wookay
Copy link
Owner

wookay commented Sep 7, 2023 •
edited

could you test it with master branch?

julia> using Pkg
julia> Pkg.develop("Octo")

you could test like this
51d5046#diff-8be19b1fddcbea3316c76de3fb4388391b75f17e597d1905d50599c9ee905568

@BrandonEscamilla
Copy link
Author

Just testing, I guess this doesn't work if the Pk is not a Int but a uuid?

wookay added a commit that referenced this issue Sep 7, 2023
@wookay
Repo.delete! with string (uuid) (issue #57)
29321f9
@wookay
Copy link
Owner

wookay commented Sep 7, 2023

@BrandonEscamilla oh. it seems to be work with uuid String.
you could test like this
29321f9#diff-78ee68626d990c0368561a382f7c86ba2614a9e5150858a9c073da98abf3b5b3

@wookay wookay mentioned this issue Sep 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wookay @BrandonEscamilla