Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to ESM #42

Closed
remcohaszing opened this issue Feb 7, 2022 · 6 comments
Closed

Convert to ESM #42

remcohaszing opened this issue Feb 7, 2022 · 6 comments

Comments

@remcohaszing
Copy link
Contributor

Because 5f2b26a introduced breaking changes, I think now would be the right time to convert to ESM.

@wooorm
Copy link
Owner

wooorm commented Feb 7, 2022

What does that commit break?
All these packages are used a lot in electron, and by folks who have no clue about Node.js/JavaScript, so im delaying this project

@remcohaszing
Copy link
Contributor Author

  • It introduces let syntax, which breaks compatibility with node 0.12
  • It introduces arrow functions, which breaks compatibility with node 0.12
  • It changes the fallback values of exception and result from null to undefined. Although technically this isn’t a breaking change, because an exception can never occur while reading the aff and dic files.

I personally don’t care for such old Node.js versions, but given the initial release date of this project and the lack of an engines field and Compatibility section in the readme, those are technically breaking changes.

@wooorm
Copy link
Owner

wooorm commented Feb 7, 2022

Node 0.12 and this project are both 7 years old. I don’t really see this problem

@wooorm
Copy link
Owner

wooorm commented Feb 7, 2022

Compared to the ESM problem, which is definitely a major

@remcohaszing
Copy link
Contributor Author

If electron support is really important, but old Node.js version support isn't, then never mind this issue 🙂

@wooorm
Copy link
Owner

wooorm commented Feb 7, 2022

A lot of folks are getting these dictionaries by manually downloading them and placing the files somewhere. They often don’t know about Node, npm, or JavaScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants