Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should treat Brazilian Portuguese and European Portuguese normally #5

Closed
wooorm opened this issue Sep 8, 2014 · 0 comments
Closed

Should treat Brazilian Portuguese and European Portuguese normally #5

wooorm opened this issue Sep 8, 2014 · 0 comments

Comments

@wooorm
Copy link
Owner

wooorm commented Sep 8, 2014

Currently they receive lower scores than other languages, but are still returned as first-choice. The latter is correct, but the scores might result in problems for implementors.
wooorm added a commit that referenced this issue Sep 30, 2014
@wooorm
Remove support for three languages
5e374dd 
- This removes the differentiation between Brazilian and European
  Portuguese, instead opting to only focus on Portuguese;
- This removes support for Klingon, because no viable trigram
  source could be found (Klingons do not sign declarations of
  human rights, it seems);
- Pashto was removed because it's a not easily recognisable
  language: their major most occurring trigram, `او `, occurs only
  four times in the UDHR: https://github.com/wooorm/trigrams/
  blob/master/data/all/pbu.json

Closes GH-5, because Portuguese is now treated ``normally''.
@wooorm wooorm closed this as completed Sep 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wooorm