Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import.meta.resolve is now defined to be _sync_ #14

Closed
giltayar opened this issue Apr 13, 2023 · 1 comment
Closed

import.meta.resolve is now defined to be _sync_ #14

giltayar opened this issue Apr 13, 2023 · 1 comment

Comments

@giltayar
Copy link
Contributor

You can see it here: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import.meta/resolve

And also in Node.js, where a PR just changed it to be synchronous: nodejs/node#44710

I can create a PR for this, if you wish. Just checking that it's OK.

@wooorm
Copy link
Owner

wooorm commented Apr 13, 2023

Hey Gil!

Oh, nice! This should be pretty straight forward in the API.
But not so sure about making the tests and the infra work:

- lts/hydrogen
- node
.
And I guess this is a breaking change?

Anyway, yeah: PR would be great, thank you!

giltayar added a commit to giltayar/import-meta-resolve that referenced this issue Apr 13, 2023
@wooorm wooorm closed this as completed in dcaeda3 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants