Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing getLanguage API #33

Closed
NullVoxPopuli opened this issue May 1, 2021 · 5 comments
Closed

missing getLanguage API #33

NullVoxPopuli opened this issue May 1, 2021 · 5 comments

Comments

@NullVoxPopuli
Copy link

getLanguage is needed for safely extending languages during overall init:

see usage here: https://github.com/NullVoxPopuli/highlightjs-glimmer/blob/main/src/index.js#L19
This was referenced May 1, 2021
Closed
Closed
@wooorm
Copy link
Owner

wooorm commented May 1, 2021

I don’t think lowlight is given to your syntax? 🤔

This:

lowlight/lib/core.js

Line 126 in 869119b

high.registerLanguage(language, syntax)

…is calling the syntax on highlight, not on lowlight?

@NullVoxPopuli
Copy link
Author

maybe my issues is more with remark-highlight.js then :-\ I'll re-investigate

@NullVoxPopuli
Copy link
Author

it seems like lowlight is getting passed to my grammar, because:
image

@NullVoxPopuli
Copy link
Author

oh duh, because I'm manually doing that, because remark-highlightjs doesn't have a way to specify plugins. oops. one sec

@NullVoxPopuli
Copy link
Author

I'll open a separate issue for this, but it looks like remark-highlightjs is expecting a default export
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add getLanguage api from hljs NullVoxPopuli/lowlight
2 participants
@NullVoxPopuli @wooorm