You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for this crate, it's got great potential!
I don't quite understand the json feature. The way I think it is done:
The json feature enables dependencies for serde and serde-json. In the code, the serializers/deserializers are derived via serde, if the json feature is enabled. The serde-json crate is not actually used.
Here is how this could be done better (I tested locally):
The serde feature enables a dependency on serde with the derive feature, as before. In the code, the serializers/deserializers are derived, as before. The serde-json crate appears nowhere.
I think this is the conventional and idiomatic way to do this. Are there things I am overlooking here?
EDIT: renamed, was "'json' feature seems half baked" which is vague and unnecessarily insulting. Sorry :)
The text was updated successfully, but these errors were encountered:
barafael
changed the title
'json' feature seems half baked
'json' feature should be called serde and serde-json should not be a dependency
Apr 12, 2023
Hi, thanks for this crate, it's got great potential!
I don't quite understand the
json
feature. The way I think it is done:The
json
feature enables dependencies forserde
andserde-json
. In the code, the serializers/deserializers are derived via serde, if thejson
feature is enabled. Theserde-json
crate is not actually used.Here is how this could be done better (I tested locally):
The
serde
feature enables a dependency onserde
with the derive feature, as before. In the code, the serializers/deserializers are derived, as before. Theserde-json
crate appears nowhere.I think this is the conventional and idiomatic way to do this. Are there things I am overlooking here?
EDIT: renamed, was "'json' feature seems half baked" which is vague and unnecessarily insulting. Sorry :)
The text was updated successfully, but these errors were encountered: