Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for enabling GFM tasklist checkedness #77

Merged
merged 2 commits into from
Aug 16, 2023
Merged

Conversation

rotmoded
Copy link
Contributor

@rotmoded rotmoded commented Aug 5, 2023

This allows you to to enable whether or not html checkbox inputs are checkable, i.e. do not have the disable="" attribute.

Apologies if the terminology is confusing, I felt it was necessary to make it immediately obvious that this doesn't enable/disable checkboxes but instead enables/disables their ability to be checked.

@wooorm
Copy link
Owner

wooorm commented Aug 6, 2023

And then? How would you use this? Uncontrolled inputs don't do anything in HTML?

@rotmoded
Copy link
Contributor Author

rotmoded commented Aug 6, 2023 via email

@wooorm
Copy link
Owner

wooorm commented Aug 6, 2023

Wouldnt you want to safe that somewhere? A server or local storage?

@rotmoded
Copy link
Contributor Author

rotmoded commented Aug 6, 2023 via email

@wooorm
Copy link
Owner

wooorm commented Aug 7, 2023

no, i don't see a need to, it's just a cute thing for people to use that will help them follow the guide while they are on the page.

I worry about this. A nice cute thing is fun and all, of course.
But these inputs are not labelled, they are not in a form, I worry about how screenreaders for example handle them.

@rotmoded
Copy link
Contributor Author

rotmoded commented Aug 7, 2023

i checked and it looks fine for screenreaders, they just get read as 'checkbox', without a 'form start' apparently

@wooorm
Copy link
Owner

wooorm commented Aug 9, 2023

ok, not against trying this out!
Looks like CI is failing? See these for help:

@rotmoded
Copy link
Contributor Author

oops! apologies, it should be all good now.
cargo test works fine, but i noticed that cargo clippy --examples --tests --benches errors out. would you like me to fix that or update the documentation? it's trivial so idk if you would want a separate pr

@wooorm
Copy link
Owner

wooorm commented Aug 15, 2023

If you’re interested in fixing it, in this PR, or even separately, then please be my guest: I appreciate it! Whatever works for you :)

@rotmoded
Copy link
Contributor Author

I went ahead, it was literally just one line so LOL

@wooorm wooorm changed the title Add ability to enable or disable html checkbox checkability Add support for enabling GFM tasklist checkedness Aug 16, 2023
@wooorm wooorm merged commit dea07bb into wooorm:main Aug 16, 2023
2 checks passed
@wooorm
Copy link
Owner

wooorm commented Aug 16, 2023

Thanks!

@wooorm
Copy link
Owner

wooorm commented Aug 16, 2023

Released! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants