issue 84: GFM strikethrough causes nested attention sequences to be considered just text data #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue I was trying to solve was that a markdown line like this
~~foo __*a*__~~
was not correctly parsed because tilde was not being considered punctuation.After changing that, the interplay between emphasis and strikethrough started failing because to implement how Github flavors it, we must consider tilde not punctuation when deciding if the sequence is the close. The interplay example is
e ***~~xxx~~***yyy
I've added a specific exception for tilde with a comment explaining why it is there.