Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 84: GFM strikethrough causes nested attention sequences to be considered just text data #88

Closed

Conversation

rawilder
Copy link
Contributor

The original issue I was trying to solve was that a markdown line like this ~~foo __*a*__~~ was not correctly parsed because tilde was not being considered punctuation.

After changing that, the interplay between emphasis and strikethrough started failing because to implement how Github flavors it, we must consider tilde not punctuation when deciding if the sequence is the close. The interplay example is e ***~~xxx~~***yyy

I've added a specific exception for tilde with a comment explaining why it is there.

@wooorm
Copy link
Owner

wooorm commented Dec 5, 2023

Thank you Adam for your work and your patience, that was interesting to solve.

I solved it more similar to how it is done in micromark.
I also noticed another bug present here: some ASCII punctuation characters are not Unicode punctuation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants