-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#7 normalization #8
Conversation
StarpTech
commented
Jul 28, 2018
- Fix Don't remove character during normalization #7
- Fix scripts args in order to support windows systems
@@ -53,7 +53,7 @@ | |||
}, | |||
"scripts": { | |||
"generate": "node script/generate-react", | |||
"format": "remark . -qfo && prettier --write '**/*.js' && xo --fix", | |||
"format": "remark . -qfo && prettier --write \"**/*.js\" && xo --fix", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do single quotes not work? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it's a common behavior.
test.js
Outdated
normalize(':class'), | ||
':class', | ||
`non-word characters should not be removed | ||
when they did not serve as a delimiter (#7)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you use the format (GH-7, #1)
here and the two below? I use the #
above as a count.
Done. |
Why did you close it? |
because I merged it |
ok, for me it's highlighted as unmerged and closed. |
Yes, but GH UI is lacking so I merge stuff often on the terminal. |