New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch up with woothee v1.10.0 #48
Conversation
1 similar comment
|
||
if ($epos > -1) { | ||
if (preg_match('#Edge/([.0-9]+)#', $ua, $matches)) { | ||
if ($epos1 > -1 || $epos2 > -1 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it checks that it starts with Edg
, Edge
check may not be necessary.
src/AgentCategory/Os/Linux.php
Outdated
@@ -17,8 +17,9 @@ public static function challenge($ua, &$result) | |||
$version = null; | |||
|
|||
if (strpos($ua, 'Android') !== false) { | |||
$data = DataSet::get('Android'); | |||
if (preg_match('/Android[- ](\\d+\\.\\d+(?:\\.\\d+)?)/', $ua, $matches)) { | |||
$data = DataSet::get('Android'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix indent.
@okonomi Thank you for your review. I've fixed where you pointed it out. Please review this again. :) |
@tell-k Thank you for your contribution! |
@okonomi
I've catched up with woothee v1.9.0 and v1.10.0.
Please feel free to merge it. Thx.