Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Use .html() instead of .text() for play/pauseText #627

Closed
wants to merge 1 commit into from

2 participants

@dominic-p

You can still style everything with CSS, but this makes it a bit more flexible, IMO. See Issue #211.

@dominic-p dominic-p Use .html() instead of .text() for play/pauseText
You can still stye everything with CSS, but this makes it a bit more
flexxible, IMO. See Issue #211.
801892f
@mattyza
Owner

Thanks for this, and your other pull requests, @dominic-p . Please keep them coming (on the "develop" branch), as you spot possible improvements or bugs that you've found solutions for.

We're always keen to review pull requests, and will review these that you've submitted in our next sprint. If they're not all included in FlexSlider 2.2.0's release, they'll be inspected there-after in the follow-up releases. :)

@mattyza
Owner

Thanks @dominic-p. I've merged this manually into the develop branch. :)

@mattyza mattyza closed this
@mattyza mattyza referenced this pull request from a commit
@mattyza mattyza Applies logic from #627. da021e3
@dominic-p dominic-p deleted the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 8, 2013
  1. @dominic-p

    Use .html() instead of .text() for play/pauseText

    dominic-p authored
    You can still stye everything with CSS, but this makes it a bit more
    flexxible, IMO. See Issue #211.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  jquery.flexslider.js
View
2  jquery.flexslider.js
@@ -315,7 +315,7 @@
}
},
update: function(state) {
- (state === "play") ? slider.pausePlay.removeClass(namespace + 'pause').addClass(namespace + 'play').text(vars.playText) : slider.pausePlay.removeClass(namespace + 'play').addClass(namespace + 'pause').text(vars.pauseText);
+ (state === "play") ? slider.pausePlay.removeClass(namespace + 'pause').addClass(namespace + 'play').html(vars.playText) : slider.pausePlay.removeClass(namespace + 'play').addClass(namespace + 'pause').html(vars.pauseText);
}
},
touch: function() {
Something went wrong with that request. Please try again.