Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to support Schema? #28

Closed
bhubbard opened this issue Aug 29, 2013 · 4 comments
Closed

Any plans to support Schema? #28

bhubbard opened this issue Aug 29, 2013 · 4 comments

Comments

@bhubbard
Copy link
Contributor

Any thoughts to modifying the template to support schema Reviews?

http://schema.org/Review

@mattyza
Copy link
Member

mattyza commented Aug 29, 2013

This sounds interesting, Brandon.

From what I see, we'd just need to add itemprop="review" itemscope itemtype="http://schema.org/Review" to each individual testimonial container, and make use of the author and description itemprops.

Is there, perhaps, a schema that is better suited to testimonials? If not, and we don't make use of all properties in the schema (such as ratings, which we don't add), would this invalidate the schema?

@bhubbard
Copy link
Contributor Author

So I started testing it by creating a single-testimonial.php file for the new site I am working on. You can find the code for the loop here: https://gist.github.com/bhubbard/6381348

Screenshots of test results using Webmaster Tools:
https://www.evernote.com/shard/s1/sh/fa77c722-6167-4d70-b8bd-6d1e914b27ee/db925f374ec72d8b4c11a04ba26fd32a

Another Screenshot:
https://www.evernote.com/shard/s1/sh/c80306ac-173f-4058-8b1b-295daaf99a0a/d73d667f2977d5b11a3aced7647626c3

So we don't need ratings, but we must have the itemReviewed for it to work in Google results. Maybe we can just set it to be the Site Name or URL? Or build a new meta field into the custom post type asking what the testimonial is regarding.

@bhubbard
Copy link
Contributor Author

bhubbard commented Oct 9, 2013

@mattyza Any more thoughts on this? Also I have a small pull request can you please take a look.

@mattyza
Copy link
Member

mattyza commented Oct 10, 2013

Apologies for the delay, Brandon.

I'll be reviewing pull requests and clearing out issues soonest, in preparation for the next version.

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Wednesday 09 October 2013 at 8:24 PM, Brandon Hubbard wrote:

@mattyza (https://github.com/mattyza) Any more thoughts on this? Also I have a small pull request can you please take a look.


Reply to this email directly or view it on GitHub (#28 (comment)).

jameskoster added a commit that referenced this issue Jan 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants