Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

href issue #43

Closed
danjjohnson opened this issue Jan 17, 2014 · 5 comments
Closed

href issue #43

danjjohnson opened this issue Jan 17, 2014 · 5 comments
Labels

Comments

@danjjohnson
Copy link

If you don't enter a URL in a testimonial, then it will just reload the page, as the href has no value - http://cld.wthms.co/jjtr

You can see this in the homepage testimonials on Upstart and Hub if you don't have a URL in your testimonials.

https://woothemes.zendesk.com/agent/#/tickets/136681

@mattyza
Copy link
Member

mattyza commented Jan 21, 2014

Thanks for reporting this, @danjjohnson.

If you use TwentyFourteen, or any other default theme, and output the testimonials in a widget or shortcode, do you receive the same result?

This should determine whether the bug is in the plugin or in a custom override of the testimonials template in each of the mentioned themes. :)

@danjjohnson
Copy link
Author

@mattyza it appears to be the themes. In default themes using the shortcode, only the testimonial author is linked, and it links to the single testimonial page.

Will open the issue in the affected themes.

@danjjohnson
Copy link
Author

@mattyza however, it does happen when I add testimonials to the TwentyThirteen homepage using

<?php do_action( 'woothemes_testimonials' ); ?>

which would suggest it is a plugin issue?

@mattyza
Copy link
Member

mattyza commented Jan 21, 2014

Sounds like a plugin-side issue as well, yep.

Matt Cohen
Chief Product Officer at WooThemes

http://woothemes.com/
http://matty.co.za/

On Tuesday 21 January 2014 at 1:38 PM, Dan Johnson wrote:

@mattyza (https://github.com/mattyza) however, it does happen when I add testimonials to the TwentyThirteen homepage using

which would suggest it is a plugin issue?


Reply to this email directly or view it on GitHub (#43 (comment)).

jameskoster added a commit that referenced this issue Mar 26, 2014
@spencerfinnell
Copy link

Would be nice if it remained linked if the URL exists. If you only want to output a logo/avatar there is no way to link it currently.

jameskoster added a commit that referenced this issue Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants