strpos() error on wc-term-functions.php line 372 version 2.1.9

[SilverKenn]

Just updated woocommerce few minutes ago,

then I notice this error after update

Warning: strpos() [function.strpos]: Empty delimiter in /......./wp-content/plugins/woocommerce/includes/wc-term-functions.php on line 372 

Its this line,

// query fields
    if ( strpos( 'COUNT(*)', $clauses['fields'] ) === false )  {
        $clauses['fields']  .= ', tm.* ';
    }

it seems that $clauses['fields'] is empty,
so I just added another if statement before that line to disable error temporarily

if ( !empty($clauses['fields']) ) {
    if ( strpos( 'COUNT(*)', $clauses['fields'] ) === false )  {
      $clauses['fields']  .= ', tm.* ';
    }
 }

not really comfortable editing the plugin directly so I hope you guys can push a fix for this

Thanks

system info

WC Version: 2.1.9
WC Database Version:    2.1.9
WP Version: 3.9.1
WP Multisite Enabled:   No
Web Server Info:    Apache
PHP Version:    5.3.2-1ubuntu4.18
MySQL Version:  5.5.27

[nathanmarks]

This fix creates another bug.

In the link_all_variations function, when it calls wc_get_product_terms with the arguments set to return slugs, the changes made here to wc_get_product_terms cause it to return names and when it sanitizes those names, it causes terms that would have identical slugs (IE 2 x 8 & 2" x 8") to conflict, resulting in this sort of thing:

This happens because 2-x-8 gets stored in the DB, even though the attribute for this product actually has the slug 2-x-8-2

[nathanmarks]

An easy fix would be to throw in

$args['fields']     = isset($args['fields']) && $args['fields'] == 'slugs' ? 'id=>slug' : 'names';

But this conditional is starting to look a bit messy/hacky, I don't have time to look at everything using this function but is there a better way to handle this?