Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variation Image Flashes Original Image #7904

Closed
roykho opened this issue Apr 8, 2015 · 4 comments
Closed

Variation Image Flashes Original Image #7904

roykho opened this issue Apr 8, 2015 · 4 comments
Assignees

Comments

@roykho
Copy link
Member

roykho commented Apr 8, 2015

So currently if you have your default attribute set to something other than the original, when the single product page loads, it will flash the original variation image/main image first and then it will display the featured image for the default selected variation.

For slower sites, the original image will stay on the screen longer and looks quite unprofessional.

We need to check for what the default attribute is set to and display the image for that right off the bat so we don't get a flash of original image. I can think of a couple ways of doing this but would like to you guys thoughts on this. @mikejolley @claudiosmweb @barrykooij

@mikejolley mikejolley added the UI label Apr 10, 2015
@mikejolley
Copy link
Member

I think this may have implications, such as when you 'reset' it needs to revert to the default product image. If this is a major issue due to speed, perhaps those speed issues would be better looked at as those IMO would have a larger impact on professionalism. This shouldn't be a problem for most sites.

@roykho
Copy link
Member Author

roykho commented Apr 10, 2015

This is on my localhost http://cld.wthms.co/1f0f3 See the flicker.

@roykho
Copy link
Member Author

roykho commented Apr 10, 2015

I propose we just load the correct image on first load instead of using JS to swap it out.

@mikejolley mikejolley added this to the 2.5 (name undecided) milestone Apr 14, 2015
@mikejolley mikejolley modified the milestones: 2.5 (name undecided), Future Milestone Jun 8, 2015
@mikejolley mikejolley modified the milestones: Future Milestone, 2.5 (name undecided) Jul 2, 2015
@mikejolley mikejolley modified the milestone: 2.5 (name undecided) Sep 9, 2015
@mikejolley
Copy link
Member

Plan: Fade in gallery/image if defaults are set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants