New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#232] 유저 테스트 코드 리팩토링 #249
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
1429c3e
refactor: 코드 정리 (#232)
da-nyee c2b8873
refactor: 사용자 유효성 검증 추가 (#232)
da-nyee 6347392
refactor: DTO 관련 네이밍 정리 (#232)
da-nyee b38cfa2
test: 컨트롤러 테스트 리팩토링 (#232)
da-nyee d6ffd7b
test: 서비스 테스트 리팩토링 (#232)
da-nyee a20fe3c
test: Data JPA 테스트 리팩토링 (#232)
da-nyee 8322923
test: 불필요한 상수 삭제 (#232)
da-nyee f5bed93
test: 유저 이름 변경 (#232)
da-nyee 51c2ffa
test: 서비스 테스트 추가 (#232)
da-nyee 86ba939
test: 서비스 테스트 리팩토링 (#232)
da-nyee e0765bd
test: 통합 테스트 리팩토링 (#232)
da-nyee 8c41dde
test: 인수 테스트 리팩토링 (#232)
da-nyee 1153ca3
refactor: Builder 사용 (#232)
da-nyee 51384da
refactor: Follow 객체에 책임 위임 (#232)
da-nyee 4547feb
test: 접근 제어자 수정 (#232)
da-nyee feb50b0
refactor: DTO 리팩토링 (#232)
da-nyee fde524c
test: 불필요한 필드 삭제 (#232)
da-nyee 0cf864e
test: WebEnvironment 옵션을 RANDOM_PORT -> NONE으로 변경 (#232)
da-nyee 3df583b
test: @SpringBootTest -> @DataJpaTest 변경 (#232)
da-nyee 44b3600
refactor: API 명세에 맞게 필드명 변경 (#232)
da-nyee File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
...ck-git/src/main/java/com/woowacourse/pickgit/user/application/dto/AuthUserServiceDto.java
This file was deleted.
Oops, something went wrong.
20 changes: 20 additions & 0 deletions
20
...rc/main/java/com/woowacourse/pickgit/user/application/dto/request/AuthUserRequestDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
package com.woowacourse.pickgit.user.application.dto.request; | ||
|
||
import lombok.Builder; | ||
|
||
@Builder | ||
public class AuthUserRequestDto { | ||
|
||
private String githubName; | ||
|
||
private AuthUserRequestDto() { | ||
} | ||
|
||
public AuthUserRequestDto(String githubName) { | ||
this.githubName = githubName; | ||
} | ||
|
||
public String getGithubName() { | ||
return githubName; | ||
} | ||
} |
14 changes: 10 additions & 4 deletions
14
...ser/application/dto/FollowServiceDto.java → ...ation/dto/response/FollowResponseDto.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀👍