[BE] issue188: 스터디 상태 자동 변경 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc0116
reviewed
Aug 4, 2022
| @@ -28,7 +28,7 @@ CREATE TABLE study | |||
| max_member_count INTEGER, | |||
| created_at DATETIME not null, | |||
| enrollment_end_date DATE, | |||
| start_date DATE, | |||
| start_date DATE not null, | |||
| @@ -27,7 +26,7 @@ private static Runnable runnable(final StudyService studyService) { | |||
| @Transactional | |||
| public void run() { | |||
| LOGGER.debug(LocalDateTime.now() + " : " + "start moamoa scheduled task!"); | |||
| studyService.autoCloseStudies(); | |||
| studyService.autoUpdateStatus(); | |||
tco0427
force-pushed
the
feat/188-study-auto-close
branch
from
46608ec
to
f10eb90
Compare
jaejae-yoo
requested changes
Aug 4, 2022
| return ResponseEntity.status(HttpStatus.NOT_FOUND).body(new ErrorResponse(e.getMessage())); | ||
| } | ||
|
|
||
| @ExceptionHandler(RuntimeException.class) | ||
| public ResponseEntity<ErrorResponse> handleInternalServerError(RuntimeException e) { | ||
| e.printStackTrace(); | ||
| log.error("RuntimeException : {}", e.getMessage()); |
| @@ -95,19 +95,20 @@ public void participate(final Long memberId) { | |||
| } | |||
| } | |||
|
|
|||
| private boolean isFullOfCapacity() { | |||
| return recruitPlanner.hasCapacity() && recruitPlanner.getCapacity() == participants.getSize(); | |||
| public void changeStatus(final LocalDate now) { | |||
| this.enrollmentEndDate = getNullableDate(study.getEnrollmentEndDate()); | ||
| this.startDate = study.getStartDate().toString(); | ||
| this.endDate = getNullableDate(study.getEndDate()); | ||
| this.maxMemberCount = study.getMaxMemberCount(); |
| final StudyPlanner studyPlanner = (StudyPlanner) o; | ||
| return Objects.equals(startDate, studyPlanner.startDate) && Objects.equals(endDate, studyPlanner.endDate); | ||
| private boolean isNeedToChangeProgress(final LocalDate now) { | ||
| return (studyStatus.equals(PREPARE)) && (startDate.isAfter(now) || startDate.isEqual(now)); |
There was a problem hiding this comment.
밑에 있는 isPreparing 메서드 써도 좋을 것 같아요!
| public StudyStatus getStudyStatus() { | ||
| return studyStatus; | ||
| private boolean isNeedToCloseStudy(final LocalDate now) { | ||
| return (endDate != null) && (studyStatus.equals(IN_PROGRESS)) && (endDate.isAfter(now) || endDate.isEqual(now)); |
There was a problem hiding this comment.
여기도 isProgress 메서드 써도 좋을 것 같습니다
jaejae-yoo
approved these changes
Aug 4, 2022
verus-j
requested changes
Aug 4, 2022
| public class RecruitPlanner { | ||
|
|
||
| @Column(name = "max_member_count") | ||
| private Integer max; | ||
|
|
||
| @Enumerated(EnumType.STRING) | ||
| @Enumerated(value = STRING) |
There was a problem hiding this comment.
넵!! 일관성 있게 나머지 @Enumerated 도 통일해주었습니다!
Comment on lines
52
to
57
| if (isNeedToCloseStudy(now)) { | ||
| studyStatus = DONE; | ||
| } | ||
| if (isNeedToChangeProgress(now)) { | ||
| studyStatus = IN_PROGRESS; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (isNeedToCloseStudy(now)) { | |
| studyStatus = DONE; | |
| } | |
| if (isNeedToChangeProgress(now)) { | |
| studyStatus = IN_PROGRESS; | |
| } | |
| if (isNeedToChangeStatus(now)) { | |
| studyStatus = nextStatus(now); | |
| } |
Comment on lines
165
to
172
| public void autoCloseStudyStatus() { | ||
| given(dateTimeSystem.now()).willReturn(LocalDateTime.now()); | ||
|
|
||
| sut.getRunnable().run(); | ||
|
|
||
| final Study linuxStudy = studyRepository.findById(linuxStudyId).orElseThrow(); | ||
|
|
||
| assertThat(linuxStudy.isCloseStudy()).isEqualTo(true); |
|
Study 불변식 확인하는 코드 부탁드려요. |
…oamoa into feat/188-study-auto-close # Conflicts: # backend/src/test/java/com/woowacourse/acceptance/study/GettingStudyDetailsAcceptanceTest.java
sc0116
approved these changes
Aug 4, 2022
…oamoa into feat/188-study-auto-close
verus-j
requested changes
Aug 4, 2022
Comment on lines
18
to
24
|
|
||
| @Bean | ||
| public ApplicationRunner runner() { | ||
| return args -> { | ||
| log.debug("hello !"); | ||
| }; | ||
| } |
verus-j
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요약
스터디 상태 자동 변경
세부사항
IN_PROGRESS상태가 된다.DONE상태가 된다.IN_PROGRESS를 유지한다.""가 아닌 "null" 을 반환한다.close #188